Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] - Removed privacy feature for creators #328

Merged
merged 5 commits into from
Sep 12, 2018
Merged

[Enhancement] - Removed privacy feature for creators #328

merged 5 commits into from
Sep 12, 2018

Conversation

Rcureton
Copy link
Contributor

What

  • Added logic to hide privacy rows when the user is a creator.
  • Added ViewModelTest functions to test if the privacy row is hidden.

Why

  • Creators can't have private profiles.

See

ksl
sep-12-2018 14-29-41-rashad

@Rcureton Rcureton requested a review from eoji September 12, 2018 18:31
eoji
eoji approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@eoji eoji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GREAT JOB. Thanks for pairing with me!

image

@Rcureton Rcureton merged commit 41ad943 into master Sep 12, 2018
@Rcureton Rcureton deleted the rc/private-row-fix branch September 12, 2018 19:46
@Rcureton
Copy link
Contributor Author

Hide Private profile from creators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eoji eoji eoji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rcureton @eoji