[Enhancement] - Removed privacy feature for creators

app/src/main/java/com/kickstarter/ui/activities/PrivacyActivity.kt

@@ -50,7 +50,16 @@ class PrivacyActivity : BaseActivity<PrivacyViewModel.ViewModel>() {
                 .observeOn(AndroidSchedulers.mainThread())
                 .subscribe({ this.displayPreferences(it) })
 
-        following_switch.setOnClickListener{ this.viewModel.inputs.optIntoFollowing(following_switch.isChecked) }
+        this.viewModel.outputs.hidePrivateProfileRow()
+                .compose(bindToLifecycle())
+                .observeOn(AndroidSchedulers.mainThread())
+                .subscribe( {
+                    ViewUtils.setGone(private_profile_row, it)
+                    ViewUtils.setGone(private_profile_text_view, it)
+                    ViewUtils.setGone(public_profile_text_view, it)
+                })
+
+        following_switch.setOnClickListener { this.viewModel.inputs.optIntoFollowing(following_switch.isChecked) }
         private_profile_switch.setOnClickListener { this.viewModel.inputs.showPublicProfile(private_profile_switch.isChecked) }
         recommendations_switch.setOnClickListener { this.viewModel.inputs.optedOutOfRecommendations(recommendations_switch.isChecked) }
         settings_request_data.setOnClickListener { showPrivacyWebpage(Secrets.Privacy.REQUEST_DATA) }
@@ -76,7 +85,7 @@ class PrivacyActivity : BaseActivity<PrivacyViewModel.ViewModel>() {
         return this.followingConfirmationDialog!!
     }
 
-    private fun showPrivacyWebpage(url : String) {
+    private fun showPrivacyWebpage(url: String) {
         val intent = Intent(Intent.ACTION_VIEW, Uri.parse(url))
         startActivity(intent)
     }

app/src/main/java/com/kickstarter/viewmodels/PrivacyViewModel.kt

@@ -5,7 +5,9 @@ import com.kickstarter.libs.ActivityViewModel
 import com.kickstarter.libs.CurrentUserType
 import com.kickstarter.libs.Environment
 import com.kickstarter.libs.rx.transformers.Transformers
+import com.kickstarter.libs.utils.IntegerUtils
 import com.kickstarter.libs.utils.ListUtils
+import com.kickstarter.libs.utils.ObjectUtils
 import com.kickstarter.models.User
 import com.kickstarter.services.ApiClientType
 import com.kickstarter.ui.activities.PrivacyActivity
@@ -32,6 +34,9 @@ interface PrivacyViewModel {
         /** Emits when Following switch should be turned back on after user cancels opting out.  */
         fun hideConfirmFollowingOptOutPrompt(): Observable<Void>
 
+        /** Emits when the user is a creator and we need to hide the private profile row. */
+        fun hidePrivateProfileRow(): Observable<Boolean>
+
         /** Emits when user should be shown the Following confirmation dialog.  */
         fun showConfirmFollowingOptOutPrompt(): Observable<Void>
 
@@ -50,6 +55,7 @@ interface PrivacyViewModel {
         private val userInput = PublishSubject.create<User>()
 
         private val hideConfirmFollowingOptOutPrompt = BehaviorSubject.create<Void>()
+        private var hidePrivateProfileRow = BehaviorSubject.create<Boolean>()
         private val showConfirmFollowingOptOutPrompt = BehaviorSubject.create<Void>()
         private val userOutput = BehaviorSubject.create<User>()
         private val updateSuccess = PublishSubject.create<Void>()
@@ -70,11 +76,19 @@ interface PrivacyViewModel {
                     .compose(bindToLifecycle())
                     .subscribe { this.currentUser.refresh(it) }
 
-            this.currentUser.observable()
+            val currentUser = this.currentUser.observable()
+
+            currentUser
                     .take(1)
                     .compose(bindToLifecycle())
                     .subscribe({ this.userOutput.onNext(it) })
 
+            currentUser
+                    .compose(bindToLifecycle())
+                    .filter(ObjectUtils::isNotNull)
+                    .map { user -> IntegerUtils.isNonZero(user.createdProjectsCount()) }
+                    .subscribe(this.hidePrivateProfileRow)
+
             this.userInput
                     .concatMap<User>({ this.updateSettings(it) })
                     .compose(bindToLifecycle())
@@ -131,6 +145,8 @@ interface PrivacyViewModel {
 
         override fun hideConfirmFollowingOptOutPrompt(): Observable<Void> = this.hideConfirmFollowingOptOutPrompt
 
+        override fun hidePrivateProfileRow(): Observable<Boolean> = this.hidePrivateProfileRow
+
         override fun showConfirmFollowingOptOutPrompt(): Observable<Void> = this.showConfirmFollowingOptOutPrompt
 
         override fun user(): Observable<User> = this.userOutput

app/src/main/res/layout/activity_privacy.xml

@@ -96,6 +96,7 @@
         android:text="@string/We_use_your_activity_internally_to_make_recommendations_for_you" />
 
       <LinearLayout
+        android:id="@+id/private_profile_row"
         style="@style/SettingsLinearRow">
 
         <LinearLayout
@@ -116,12 +117,14 @@
       </LinearLayout>
 
       <TextView
+        android:id="@+id/private_profile_text_view"
         style="@style/NewsLetterTextView"
         android:layout_marginBottom="@dimen/grid_1"
         android:layout_marginTop="@dimen/grid_2"
         android:text="@string/If_your_profile_is_private" />
 
       <TextView
+        android:id="@+id/public_profile_text_view"
         style="@style/NewsLetterTextView"
         android:layout_marginBottom="@dimen/grid_3"
         android:text="@string/If_your_profile_is_public" />

app/src/test/java/com/kickstarter/viewmodels/PrivacyViewModelTest.kt

@@ -1,8 +1,8 @@
 package com.kickstarter.viewmodels
 
 import com.kickstarter.KSRobolectricTestCase
-import com.kickstarter.mock.factories.UserFactory
 import com.kickstarter.libs.MockCurrentUser
+import com.kickstarter.mock.factories.UserFactory
 import com.kickstarter.models.User
 import org.junit.Test
 import rx.observers.TestSubscriber
@@ -12,6 +12,7 @@ class PrivacyViewModelTest : KSRobolectricTestCase() {
 
     private val currentUserTest = TestSubscriber<User>()
     private val hideConfirmFollowingOptOutPrompt = TestSubscriber<Void>()
+    private val hidePrivateProfile = TestSubscriber<Boolean>()
     private val showConfirmFollowingOptOutPrompt = TestSubscriber<Void>()
 
     private fun setUpEnvironment(user: User) {
@@ -86,6 +87,24 @@ class PrivacyViewModelTest : KSRobolectricTestCase() {
         this.hideConfirmFollowingOptOutPrompt.assertNoValues()
     }
 
+    @Test
+    fun testHidePrivateProfileRow_isFalse() {
+        val creator = UserFactory.creator()
+        setUpEnvironment(creator)
+
+        this.vm.outputs.hidePrivateProfileRow().subscribe(this.hidePrivateProfile)
+        this.hidePrivateProfile.assertValue(true)
+    }
+
+    @Test
+    fun testHidePrivateProfileRow_isTrue() {
+        val notCreator = UserFactory.user().toBuilder().createdProjectsCount(0).build()
+        setUpEnvironment(notCreator)
+
+        this.vm.outputs.hidePrivateProfileRow().subscribe(this.hidePrivateProfile)
+        this.hidePrivateProfile.assertValue(false)
+    }
+
     @Test
     fun testOptedOutOfRecommendations() {
         val user = UserFactory.noRecommendations()