[Enhancement] - User can successfully change Email #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for the spinner (#326)
* completed screen for change email * added proper dimens from dimens.xml * fixed pr feedback
* added change password screen, toolbar and added style for textinputlayout * refactored styles
* added cells for edit profile and change password * made rows for account in settings and added account activity layout with rows * added toolbar layout, account layout, AccountActivity, Updated SettingsNewViewModel * added edit text and line restrictions * re-added tests that were deleted accidentally * fixed lines and spacing issues * fixed imports * fixed more imports * moved the tests into the right package * setup edit profile cell and added the activity * added toolbar and imageview to edit profile * still fixing layout * updated strings, completed edit profile ui * removed duplicate activity in manifest and sample layout * fixed circle issues * added icon for different screen mods * fixed error * fixed more errors * fixed the last error
eoji
suggested changes
Sep 25, 2018
| this.view.layoutParams = params | ||
| this.view.background = ContextCompat.getDrawable(context, R.drawable.change_email_success_bg) | ||
| ViewCompat.setElevation(this.view, 6f) | ||
| } |
| import com.kickstarter.R | ||
|
|
||
| fun Snackbar.success(context: Context) { | ||
| val params = this.view.layoutParams as ViewGroup.MarginLayoutParams |
There was a problem hiding this comment.
Magic numbers make code harder to understand.
Let's try something like this instead:
val grid1 = context.resources.getDimensionPixelSize(R.dimen.grid_1)
val grid2 = context.resources.getDimensionPixelSize(R.dimen.grid_2)
params.setMargins(grid1, 0, grid1, grid2)
| @@ -12,6 +17,9 @@ import rx.subjects.PublishSubject | |||
| interface ChangeEmailViewModel { | |||
|
|
|||
| interface Inputs { | |||
| /** Call when the make network call button has been clicked. */ | |||
There was a problem hiding this comment.
This looks like copy pasta 👀 🍝
| /** Emits a boolean that determines if a network call is in progress. */ | ||
| fun showProgressBar(): Observable<Boolean> | ||
|
|
||
| /** Emits the logged in user's email which we use get the success of the mutation. */ |
There was a problem hiding this comment.
Are you doing anything with this value?
| android:shape="rectangle"> | ||
| <solid android:color="@color/ksr_cobalt_500" /> | ||
| <corners android:radius="@dimen/grid_1" /> | ||
| </shape> |
|
|
||
| class ChangeEmailViewModelTest : KSRobolectricTestCase() { | ||
|
|
||
| private lateinit var vm: TestApolloViewModel.ViewModel |
There was a problem hiding this comment.
Shouldn't this be ChangeEmailViewModel.ViewModel?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
UIis accurate if you switch to production the Gif is on staging.Snackbarbackground.masterand a prior branch hence all the file changes.Story
See 👀