[Enhancement] - Change Password screen #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoji
reviewed
Sep 13, 2018
app/src/main/res/values/styles.xml
Outdated
| <item name="android:layout_marginEnd">@dimen/activity_horizontal_margin</item> | ||
| </style> | ||
|
|
||
| <style name="ChangeEmailPassTextInputEditTextMarginBottom" parent="CalloutPrimary"> |
There was a problem hiding this comment.
This can inherit from ChangeEmailPassTextInputEditText and then all you need is <item name="android:layout_marginTop">@dimen/grid_1</item>.
Also should you rename this to ChangeEmailPassTextInputEditTextMarginTop
Rcureton
pushed a commit
that referenced
this pull request
Sep 25, 2018
* added account screen with all necessary fields also added the strings for the spinner (#326) * refactored method in account activity * removed shipping addresses as per the card * [Enhancement] - Completed Change Email screen layout (#329) * completed screen for change email * added proper dimens from dimens.xml * fixed pr feedback * [Enhancement] - Change Password screen (#330) * added change password screen, toolbar and added style for textinputlayout * refactored styles * [Enhancement] - User can see Edit Profile Screen (#338) * added cells for edit profile and change password * made rows for account in settings and added account activity layout with rows * added toolbar layout, account layout, AccountActivity, Updated SettingsNewViewModel * added edit text and line restrictions * re-added tests that were deleted accidentally * fixed lines and spacing issues * fixed imports * fixed more imports * moved the tests into the right package * setup edit profile cell and added the activity * added toolbar and imageview to edit profile * still fixing layout * updated strings, completed edit profile ui * removed duplicate activity in manifest and sample layout * fixed circle issues * added icon for different screen mods * fixed error * fixed more errors * fixed the last error * added viewmodel to change email
Rcureton
pushed a commit
that referenced
this pull request
Sep 25, 2018
* added account screen with all necessary fields also added the strings for the spinner (#326) * refactored method in account activity * removed shipping addresses as per the card * [Enhancement] - Completed Change Email screen layout (#329) * completed screen for change email * added proper dimens from dimens.xml * fixed pr feedback * [Enhancement] - Change Password screen (#330) * added change password screen, toolbar and added style for textinputlayout * refactored styles * [Enhancement] - User can see Edit Profile Screen (#338) * added cells for edit profile and change password * made rows for account in settings and added account activity layout with rows * added toolbar layout, account layout, AccountActivity, Updated SettingsNewViewModel * added edit text and line restrictions * re-added tests that were deleted accidentally * fixed lines and spacing issues * fixed imports * fixed more imports * moved the tests into the right package * setup edit profile cell and added the activity * added toolbar and imageview to edit profile * still fixing layout * updated strings, completed edit profile ui * removed duplicate activity in manifest and sample layout * fixed circle issues * added icon for different screen mods * fixed error * fixed more errors * fixed the last error * added viewmodel to change email * setting up call to change email * still trying to retrieve user email * completed change email screen with logic * fixed circle errors * added contentDescription * added test and removed certain fields * fixed broken test * fixed test * added email mutation test * removed copy pasta * fixed merge conflicts and pr feedback * added new line to snackbar ext * removed url * changed success to void * fixed url again
Rcureton
pushed a commit
that referenced
this pull request
Oct 8, 2018
* added account screen with all necessary fields also added the strings for the spinner (#326) * refactored method in account activity * removed shipping addresses as per the card * [Enhancement] - Completed Change Email screen layout (#329) * completed screen for change email * added proper dimens from dimens.xml * fixed pr feedback * [Enhancement] - Change Password screen (#330) * added change password screen, toolbar and added style for textinputlayout * refactored styles * [Enhancement] - User can see Edit Profile Screen (#338) * added cells for edit profile and change password * made rows for account in settings and added account activity layout with rows * added toolbar layout, account layout, AccountActivity, Updated SettingsNewViewModel * added edit text and line restrictions * re-added tests that were deleted accidentally * fixed lines and spacing issues * fixed imports * fixed more imports * moved the tests into the right package * setup edit profile cell and added the activity * added toolbar and imageview to edit profile * still fixing layout * updated strings, completed edit profile ui * removed duplicate activity in manifest and sample layout * fixed circle issues * added icon for different screen mods * fixed error * fixed more errors * fixed the last error * added dialog for currency change * fixed changes from PR review with Izzy * added currency enum and graph mutation * Fixing the test :3 * successful tests and handling errors and stuff * fixed tests added success and error messages * fixed and removed lines of code * fixed PR feedback and added default value for spinner if user has no chosen currency * addressed pr feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
v2features.See