Change password #344
Merged
Change password #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e doing almost the whole thing. i'll write a better commit message when i open the PR
Deriving Graphql endpoint from web endpoint so we don't have to manually change it for staging. Created Activity extensions for showing Snackbars. Created reusable Snackbar extensions for success and error messages. The Snackbar extensions return themselves so you can chain them (if you wanted to inflate a success/error snackbar manually). Change password: Showing warning when new password is less than 6 characters. Showing warning when confirm password is not equal to new confirm. Disabling save button until all validations pass. Added 2 new LoginReasons: CHANGE_PASSWORD and RESET_PASSWORD because we want to prefill the email if it's supplied from the intent but need to check if we're showing the reset dialog or change password snackbar. When password is successfully changed, taking user to LoginActivity. LoginActivity shows success snackbar letting the user know their changes were saved. Made LoginActivity's root a CoordinatorLayout so the Snackbar is shown over the keyboard.
Rcureton
suggested changes
Oct 3, 2018
| @RequiresActivityViewModel(ChangePasswordViewModel.ViewModel::class) | ||
| class ChangePasswordActivity : BaseActivity<ChangePasswordViewModel.ViewModel>() { | ||
|
|
||
| var saveEnabled = false |
| } | ||
| } | ||
|
|
||
| companion object { |
There was a problem hiding this comment.
You can define this at the top of the class I think instead of a companion object because no other class is accessing this constant
const val MINIMUM_PASSWORD_LENGTH = 6
interface ChangePasswordViewModel {
Rcureton
approved these changes
Oct 3, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what did i do?
TLDR; the most.
Updated strings.
Added mutation for changing password.
Added green check icon.
Deriving GraphQL endpoint from web endpoint so we don't have to manually change it for staging.
Changed staging toolbar to grey so we can see green toolbar icons.
Also fixed it in XML previews.
Created
Activityextensions for showingSnackbars.Created reusable
Snackbarextensions for success and error messages.The
Snackbarextensions return themselves so you can chain them (if you wanted to inflate a success/errorSnackbarmanually).Change password:
Showing warning when new password is less than 6 characters.
Showing warning when confirm password is not equal to new confirm.
Disabling save button until all validations pass.
Added 2 new
LoginReasons:CHANGE_PASSWORDandRESET_PASSWORDbecause we want to prefill the email if it's supplied from the intent but need to check if we're showing the reset dialog or change password Snackbar.Moved the text changed listeners to before we subscribe to the
prefillEmailoutput.When password is successfully changed, taking user to
LoginActivity.LoginActivity shows success
Snackbarletting the user know their changes were saved.Made LoginActivity's root a
CoordinatorLayoutso theSnackbaris shown over the keyboard.Tests on tests on tests.
see
what's left?
Final copy.