Staging toolbar part 2 #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❓
In the first pass #334, I made the toolbar the accent color when we were not hitting prod.
In the second pass #344, I made the toolbar
ksr_dark_grey_400because you couldn't see buttons that also were the accent color.In this third (and hopefully final) pass, I'm showing a cobalt stripe on toolbar when we're not hitting prod.
y tho
It's super helpful for us to know when we're not hitting the production server but it's visually distracting to change the whole toolbar's background. This is a good compromise.
See 👀