Rc/update currency #345
Merged
Rc/update currency #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for the spinner (#326)
* completed screen for change email * added proper dimens from dimens.xml * fixed pr feedback
* added change password screen, toolbar and added style for textinputlayout * refactored styles
* added cells for edit profile and change password * made rows for account in settings and added account activity layout with rows * added toolbar layout, account layout, AccountActivity, Updated SettingsNewViewModel * added edit text and line restrictions * re-added tests that were deleted accidentally * fixed lines and spacing issues * fixed imports * fixed more imports * moved the tests into the right package * setup edit profile cell and added the activity * added toolbar and imageview to edit profile * still fixing layout * updated strings, completed edit profile ui * removed duplicate activity in manifest and sample layout * fixed circle issues * added icon for different screen mods * fixed error * fixed more errors * fixed the last error
eoji
suggested changes
Oct 4, 2018
There was a problem hiding this comment.
Nice job but had some feedback.
Most notably is the app crashes when I open the Account screen while logged into my personal account.
Here's the error I get:
Caused by: java.lang.IllegalStateException: it must not be null
at com.kickstarter.ui.activities.AccountActivity$onCreate$1.call(AccountActivity.kt:37)
at com.kickstarter.ui.activities.AccountActivity$onCreate$1.call(AccountActivity.kt:23)
| import kotlinx.android.synthetic.main.activity_account.* | ||
| import kotlinx.android.synthetic.main.change_password_toolbar.* |
| getString(R.string.Currency_GBP), getString(R.string.Currency_HKD), getString(R.string.Currency_JPY), | ||
| getString(R.string.Currency_MXN), getString(R.string.Currency_NOK), getString(R.string.Currency_NZD), | ||
| getString(R.string.Currency_SEK), getString(R.string.Currency_SGD), getString(R.string.Currency_USD)) | ||
| private fun setSpinnerSelection(currencyCode: String) { |
There was a problem hiding this comment.
let's alphabetize these private methods
| /** Emits the current user's chosen Currency. */ | ||
| fun chosenCurrency(): Observable<String> | ||
|
|
||
| /** Emits a string to display when network could not be found. */ |
There was a problem hiding this comment.
this emits whenever there's an error
| /** Emits when the progress bar should be visible. */ | ||
| fun progressBarIsVisible(): Observable<Boolean> | ||
|
|
||
| /** Emits when the currency update was unsuccessful. */ |
There was a problem hiding this comment.
I think this should be when it's successful
eoji
approved these changes
Oct 8, 2018
| /** Emits the current user's chosen Currency. */ | ||
| fun chosenCurrency(): Observable<String> | ||
|
|
||
| /** Emits whenever there is an error. */ |
There was a problem hiding this comment.
I think you could be a little more descriptive 😛
| } | ||
|
|
||
| @Test | ||
| fun testError() { |
There was a problem hiding this comment.
You're not actually testing anything here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
See 👀