[Enhancement] - removed most funded and fixed the tabs style #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoji
reviewed
Oct 15, 2018
| @@ -55,7 +55,7 @@ | |||
| android:layout_height="?android:attr/actionBarSize" | |||
| android:layout_gravity="bottom" | |||
| app:tabBackground="@drawable/click_indicator_light" | |||
| app:tabMode="scrollable" | |||
| app:tabMode="fixed" | |||
| @@ -347,7 +347,7 @@ public void testClearingPages() { | |||
| .build() | |||
| ); | |||
|
|
|||
| this.clearPages.assertValues(Arrays.asList(0, 1, 2, 3), Arrays.asList(0, 2, 3, 4)); | |||
| this.clearPages.assertValues(Arrays.asList(0, 1, 2, 3), Arrays.asList(0, 2, 3)); | |||
There was a problem hiding this comment.
o_O what is this testing? or rather, why does removing 4 make this test pass? O_o
There was a problem hiding this comment.
Have no idea at all I was actually confused about this test 馃
eoji
approved these changes
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
See 馃憖