Fixes DiscoveryViewModelTest.testClearingPages #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rcureton
approved these changes
Oct 18, 2018
Rcureton
pushed a commit
that referenced
this pull request
Oct 18, 2018
* removed most funded and fixed the tabs style * removed most funded from tests * fixed broken test * Fixes testClearingPages (#356)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
how
The
clearPagesoutputEmits a list of pages that should be cleared of all their content.which translates to all of the pages but the current one. Since we got rid of the last sort, our indices went from [0,1,2,3,4] to [0,1,2,3]. Doingthis.vm.inputs.discoveryPagerAdapterSetPrimaryPage(null, 4)is an illegal condition since position 4 doesn't exist and it will never get "cleared" because it doesn't actually exist.