User can view shipping countries from pledge screen #517
Conversation
…e called multiple times
…into reward-shipping
| android:layout_width="@dimen/plus_sign_width" | ||
| android:layout_height="@dimen/plus_sign_height" | ||
| android:backgroundTint="@color/ksr_grey_500" | ||
| android:src="@drawable/ic_add" |
There was a problem hiding this comment.
It's too small and it's the wrong color.
There was a problem hiding this comment.
I fixed the color! Also the abstract has properties of 20dp for height and 9dp for width
There was a problem hiding this comment.
A drawable has intrinsic padding so when you said a fixed size and not a scaletype, it doesn't take that into account. It's too small.
|
I took another look and I can still reproduce both bugs.
I would very much like to work on the checkout mutation this sprint and this PR is blocking that work. I think we should timebox these bugs to Tuesday EOD so this PR doesn't stay open any longer. |
…into reward-shipping
…o be affected by the keyboard
…ing rule selected.
…into reward-shipping
# Conflicts: # app/src/main/java/com/kickstarter/libs/KSCurrency.java # app/src/main/java/com/kickstarter/ui/fragments/PledgeFragment.kt # app/src/main/java/com/kickstarter/viewmodels/HorizontalRewardViewHolderViewModel.kt # app/src/main/java/com/kickstarter/viewmodels/PledgeFragmentViewModel.kt # app/src/main/java/com/kickstarter/viewmodels/RewardViewModel.java # app/src/test/java/com/kickstarter/KSCurrencyTest.java
What ❓
native checkoutfeature.How to QA? 🤔
native checkout feature flagenabled -> select a reward -> on the pledge screenStory 📖
User can view shipping countries from pledge screen
See 👀