[🔢] Currency refactor 2 #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y requires the country code and KSCurrency.getCurrencySymbol to return currency symbols for a country. By default, we round DOWN, so I created KSCurrency.format that only takes in a value and project. If we're rounding DOWN, we floor the number, or else we just leave it as is. There shouldn't be any platform dependent code in unit tests so KSCurrency never returns a SpannableString. Updated KSCurrencyTest to show how rounding works and added tests for formatWithUserPreference with new precision option. Added StringUtils.trim to remove trailing white space characters with tests. Added ViewUtils.styleCurrency to return stylized currency. Both examples in ShippingRuleFactory returned the same amount so there was no way to actually test that the number updated. Updated RewardViewModelTests to show how rounding works.
Rcureton
approved these changes
Jun 7, 2019
| * Returns a string with no leading or trailing whitespace. | ||
| */ | ||
| public static String trim(final @NonNull String str) { | ||
| return str.replace('\u00A0', ' ').trim(); |
| @@ -69,10 +69,10 @@ interface PledgeFragmentViewModel { | |||
| /** Emits a boolean determining if the continue button should be hidden. */ | |||
| fun continueButtonIsGone(): Observable<Boolean> | |||
|
|
|||
| /** Set the USD conversion. */ | |||
| /** Emits a string representing the total pledge amount in the user's preferred currency. */ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❓
My fourth and hopefully final refactor of
KSCurrency.KSCurrency.currencyNeedsCodeto determine if a country's currency requires the country code and KSCurrency.getCurrencySymbol to return currency symbols for a country. These are helper methods to do the spanned currencies. Currently only shown in thePledgeFragment.DOWN, so I createdKSCurrency.formatthat only takes in a value and project.DOWN, we floor the number, or else we just leave it as is.KSCurrencynever returns aSpannableString.KSCurrencyTestto show how rounding works and added tests forformatWithUserPreferencewith new precision option.StringUtils.trimto remove trailing white space characters with tests.ViewUtils.styleCurrencyto return stylized currency.ShippingRuleFactoryreturned the same amount so there was no way to actually test that the number updated.*RewardViewModelTeststo show how rounding works.How to QA? 🤔
PledgeFragment.Story 📖
This is a refactor that was necessary after #517 was merged without any tests for the currency code.