New take on VM structure #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luoser
approved these changes
Jan 27, 2017
| interface Inputs extends ActivityFeedAdapter.Delegate { | ||
| /** | ||
| * Invoke when pagination should happen. | ||
| */ |
There was a problem hiding this comment.
maybe we should single-line these comments like so:
/** Invoke when pagination should happen. */that way we can keep this comment style if need be for longer comments, but keep these interfaces from getting too long
There was a problem hiding this comment.
totes, much better
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we have 3 files for every view model: the inputs interface, outputs interface and the main view model. That's a bit of a bummer, and makes it difficult to see everything a VM is about in one file. We did this cause Java doesnt like multiple sibling classes/interfaces to sit in the same file :/
So, to fix, let's just add a namespace that will house the inputs/outputs/vm all at once. That's what I've done here. Whatdyall think?