Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🍔] NT-811 Added Hamburger Menu Clicked event #716

Merged
merged 1 commit into from
Jan 17, 2020
Merged

[🍔] NT-811 Added Hamburger Menu Clicked event #716

merged 1 commit into from
Jan 17, 2020

Conversation

eoji
Copy link
Contributor

@eoji eoji commented Jan 17, 2020 •
edited by jira bot
Loading

📲 What

Adding Hamburger Menu Clicked event.

🤔 Why

We have new Discovery events.

🛠 How

  • Added LakeEvent.HAMBURGER_MENU_CLICKED const
  • Calling lake.trackHamburgerMenuClicked when user clicks the menu icon or slides the drawer open
  • Added Lake tests in DiscoveryFragmentViewModelTest.testDrawerData

👀 See

No visual changes.

📋 QA

So many ways 2 QA:

  • ktk the staging lake
  • check the Logcat in Android Studio
  • Look at the dev project in Amplitude

Story 📖

NT-811

@eoji eoji requested a review from ifbarrera January 17, 2020 15:09
@eoji eoji merged commit 319b0ea into master Jan 17, 2020
@eoji eoji deleted the NT-811 branch January 17, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifbarrera ifbarrera ifbarrera approved these changes

Assignees
No one assigned
Labels
events 🛤
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eoji @ifbarrera