[NT-423] Remove hardcoded feature flag (#906)

kickstarter · Oct 25, 2019 · 22466c1 · 22466c1
1 parent 0c0faf2
commit 22466c1
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 42 deletions.
diff --git a/Library/Extensions/Feature+Helpers.swift b/Library/Extensions/Feature+Helpers.swift
@@ -6,9 +6,6 @@ public func featureNativeCheckoutIsEnabled() -> Bool {
 }
 
 public func featureNativeCheckoutPledgeViewIsEnabled() -> Bool {
-  // native checkout pledge view is currently not available in release builds
-  guard !AppEnvironment.current.mainBundle.isRelease else { return false }
-
   return Feature.nativeCheckoutPledgeView.isEnabled()
 }
 

diff --git a/Library/Extensions/Feature+HelpersTests.swift b/Library/Extensions/Feature+HelpersTests.swift
@@ -56,43 +56,4 @@ final class FeatureHelpersTests: TestCase {
       XCTAssertFalse(featureNativeCheckoutPledgeViewIsEnabled())
     }
   }
-
-  func testFeatureNativeCheckoutPledgeViewEnabled_isFalse_ffIsFalse_inReleaseBuild() {
-    let testBundle = MockBundle.init(
-      bundleIdentifier: KickstarterBundleIdentifier.release.rawValue,
-      lang: "en"
-    )
-    let config = Config.template
-      |> \.features .~ [Feature.nativeCheckoutPledgeView.rawValue: false]
-
-    withEnvironment(config: config, mainBundle: testBundle) {
-      XCTAssertFalse(featureNativeCheckoutPledgeViewIsEnabled())
-    }
-  }
-
-  func testFeatureNativeCheckoutPledgeViewEnabled_isFalse_ffIsTrue_inReleaseBuild() {
-    let testBundle = MockBundle.init(
-      bundleIdentifier: KickstarterBundleIdentifier.release.rawValue,
-      lang: "en"
-    )
-    let config = Config.template
-      |> \.features .~ [Feature.nativeCheckoutPledgeView.rawValue: true]
-
-    withEnvironment(config: config, mainBundle: testBundle) {
-      XCTAssertFalse(featureNativeCheckoutPledgeViewIsEnabled())
-    }
-  }
-
-  func testFeatureNativeCheckoutPledgeViewEnabled_isFalse_ffIsNil_inReleaseBuild() {
-    let testBundle = MockBundle.init(
-      bundleIdentifier: KickstarterBundleIdentifier.release.rawValue,
-      lang: "en"
-    )
-    let config = Config.template
-      |> \.features .~ [:]
-
-    withEnvironment(config: config, mainBundle: testBundle) {
-      XCTAssertFalse(featureNativeCheckoutPledgeViewIsEnabled())
-    }
-  }
 }