[NT-423] Remove Native Pledge Screen Feature Flag Override #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Removes some hard-coded behavior that forces the
nativeCheckoutPledgeViewfeature flag to default tofalseon release builds.🤔 Why
This behavior was added to past builds to ensure that we could turn on the feature flag in the future without introducing incomplete behavior to older clients. Now that we are almost ready to release the next version of the app that will have a complete checkout experience, we can remove that hard-coded behavior. This will allow us to use the
nativeCheckoutPledgeViewfeature flag to actually enable the native pledge screen feature for users on the next release, without affecting older builds.🛠 How
Removed the hard-coded
return falsebehavior for release builds. Also removed the associated tests.👀 See
See how a
Releasebuild with theios_native_checkout_pledge_viewturned ON for my user respects the feature flag and takes the user to the new pledge screen:♿️ Accessibility
N/A
🏎 Performance
N/A
✅ Acceptance criteria
Releasemode. Go to the production admin feature flags page, and turn theios_native_checkout_pledge_viewfeature flag ON for just your user. Then, navigate to a project and choose a reward. You should be taken to the new pledge screen.