[No Ticket] Full MockOptimizely Removal PR Fixes/Cleanup (#1825)

* add tests for RemoteConfigClientConfiguredNotification & RemoteConfigClientConfigurationFailedNotification * remove redunant test * simplify paymentSheetEnabled properties * simplify campaignTabEnabled property * cleanup test name * remove snapshots associated with the test: testLoggedIn_Backer_LiveProject_NotShowingCampaign_Success * remove snapshot tests for: testView_CurrentUser_LoggedIn_IsBacking
kickstarter · Jun 12, 2023 · 7015f3b · 7015f3b
1 parent 0e92dd6
commit 7015f3b
Show file tree

Hide file tree

Showing 26 changed files with 33 additions and 40 deletions.
diff --git a/Kickstarter-iOS/AppDelegateViewModelTests.swift b/Kickstarter-iOS/AppDelegateViewModelTests.swift
@@ -2448,6 +2448,34 @@ final class AppDelegateViewModelTests: TestCase {
       self.presentViewController.assertValues([1])
     }
   }
+
+  func testRemoteConfigClientConfiguredNotification_Success() {
+    let mockService = MockService(serverConfig: ServerConfig.staging)
+
+    withEnvironment(apiService: mockService) {
+      self.postNotificationName.assertDidNotEmitValue()
+
+      self.vm.inputs.applicationDidFinishLaunching(application: UIApplication.shared, launchOptions: nil)
+
+      self.vm.inputs.didUpdateRemoteConfigClient()
+
+      self.postNotificationName.assertValues([.ksr_remoteConfigClientConfigured])
+    }
+  }
+
+  func testRemoteConfigClientConfigurationFailedNotification() {
+    let mockService = MockService(serverConfig: ServerConfig.staging)
+
+    withEnvironment(apiService: mockService) {
+      self.postNotificationName.assertDidNotEmitValue()
+
+      self.vm.inputs.applicationDidFinishLaunching(application: UIApplication.shared, launchOptions: nil)
+
+      self.vm.inputs.remoteConfigClientConfigurationFailed()
+
+      self.postNotificationName.assertValues([.ksr_remoteConfigClientConfigurationFailed])
+    }
+  }
 }
 
 private let backingForCreatorPushData: [String: Any] = [

diff --git a/Kickstarter-iOS/Features/Comments/Controllers/CommentsViewControllerTests.swift b/Kickstarter-iOS/Features/Comments/Controllers/CommentsViewControllerTests.swift
@@ -174,35 +174,6 @@ internal final class CommentsViewControllerTests: TestCase {
     }
   }
 
-  func testView_CurrentUser_LoggedIn_IsBacking() {
-    let mockService =
-      MockService(fetchProjectCommentsEnvelopeResult: .success(CommentsEnvelope.multipleCommentTemplate))
-
-    let project = Project.template
-      |> \.personalization.isBacking .~ true
-
-    combos(Language.allLanguages, [Device.phone4_7inch, Device.pad]).forEach {
-      language, device in
-      withEnvironment(
-        apiService: mockService,
-        currentUser: .template,
-        language: language
-      ) {
-        let controller = CommentsViewController.configuredWith(project: project)
-        let (parent, _) = traitControllers(device: device, orientation: .portrait, child: controller)
-        parent.view.frame.size.height = 1_100
-
-        self.scheduler.run()
-
-        assertSnapshot(
-          matching: parent.view,
-          as: .image,
-          named: "Comments - lang_\(language)_device_\(device)"
-        )
-      }
-    }
-  }
-
   func testView_NoComments_ShouldShowEmptyState() {
     AppEnvironment.pushEnvironment(
       apiService: MockService(

diff --git a/...erTests/testView_CurrentUser_LoggedIn_IsBacking.Comments-lang_de_device_pad.png b/...erTests/testView_CurrentUser_LoggedIn_IsBacking.Comments-lang_de_device_pad.png
diff --git a/...estView_CurrentUser_LoggedIn_IsBacking.Comments-lang_de_device_phone4_7inch.png b/...estView_CurrentUser_LoggedIn_IsBacking.Comments-lang_de_device_phone4_7inch.png
diff --git a/...erTests/testView_CurrentUser_LoggedIn_IsBacking.Comments-lang_en_device_pad.png b/...erTests/testView_CurrentUser_LoggedIn_IsBacking.Comments-lang_en_device_pad.png
diff --git a/...estView_CurrentUser_LoggedIn_IsBacking.Comments-lang_en_device_phone4_7inch.png b/...estView_CurrentUser_LoggedIn_IsBacking.Comments-lang_en_device_phone4_7inch.png
diff --git a/...erTests/testView_CurrentUser_LoggedIn_IsBacking.Comments-lang_es_device_pad.png b/...erTests/testView_CurrentUser_LoggedIn_IsBacking.Comments-lang_es_device_pad.png
diff --git a/...estView_CurrentUser_LoggedIn_IsBacking.Comments-lang_es_device_phone4_7inch.png b/...estView_CurrentUser_LoggedIn_IsBacking.Comments-lang_es_device_phone4_7inch.png
diff --git a/...erTests/testView_CurrentUser_LoggedIn_IsBacking.Comments-lang_fr_device_pad.png b/...erTests/testView_CurrentUser_LoggedIn_IsBacking.Comments-lang_fr_device_pad.png
diff --git a/...estView_CurrentUser_LoggedIn_IsBacking.Comments-lang_fr_device_phone4_7inch.png b/...estView_CurrentUser_LoggedIn_IsBacking.Comments-lang_fr_device_phone4_7inch.png
diff --git a/...erTests/testView_CurrentUser_LoggedIn_IsBacking.Comments-lang_ja_device_pad.png b/...erTests/testView_CurrentUser_LoggedIn_IsBacking.Comments-lang_ja_device_pad.png
diff --git a/...estView_CurrentUser_LoggedIn_IsBacking.Comments-lang_ja_device_phone4_7inch.png b/...estView_CurrentUser_LoggedIn_IsBacking.Comments-lang_ja_device_phone4_7inch.png
diff --git a/...stLoggedIn_Backer_LiveProject_NotShowingCampaign_Success.lang_de_device_pad.png b/...stLoggedIn_Backer_LiveProject_NotShowingCampaign_Success.lang_de_device_pad.png
diff --git a/...dIn_Backer_LiveProject_NotShowingCampaign_Success.lang_de_device_phone4inch.png b/...dIn_Backer_LiveProject_NotShowingCampaign_Success.lang_de_device_phone4inch.png
diff --git a/...stLoggedIn_Backer_LiveProject_NotShowingCampaign_Success.lang_en_device_pad.png b/...stLoggedIn_Backer_LiveProject_NotShowingCampaign_Success.lang_en_device_pad.png
diff --git a/...dIn_Backer_LiveProject_NotShowingCampaign_Success.lang_en_device_phone4inch.png b/...dIn_Backer_LiveProject_NotShowingCampaign_Success.lang_en_device_phone4inch.png
diff --git a/...stLoggedIn_Backer_LiveProject_NotShowingCampaign_Success.lang_es_device_pad.png b/...stLoggedIn_Backer_LiveProject_NotShowingCampaign_Success.lang_es_device_pad.png
diff --git a/...dIn_Backer_LiveProject_NotShowingCampaign_Success.lang_es_device_phone4inch.png b/...dIn_Backer_LiveProject_NotShowingCampaign_Success.lang_es_device_phone4inch.png
diff --git a/...stLoggedIn_Backer_LiveProject_NotShowingCampaign_Success.lang_fr_device_pad.png b/...stLoggedIn_Backer_LiveProject_NotShowingCampaign_Success.lang_fr_device_pad.png
diff --git a/...dIn_Backer_LiveProject_NotShowingCampaign_Success.lang_fr_device_phone4inch.png b/...dIn_Backer_LiveProject_NotShowingCampaign_Success.lang_fr_device_phone4inch.png
diff --git a/...stLoggedIn_Backer_LiveProject_NotShowingCampaign_Success.lang_ja_device_pad.png b/...stLoggedIn_Backer_LiveProject_NotShowingCampaign_Success.lang_ja_device_pad.png
diff --git a/...dIn_Backer_LiveProject_NotShowingCampaign_Success.lang_ja_device_phone4inch.png b/...dIn_Backer_LiveProject_NotShowingCampaign_Success.lang_ja_device_phone4inch.png
diff --git a/Library/ViewModels/PaymentMethodsViewModel.swift b/Library/ViewModels/PaymentMethodsViewModel.swift
@@ -53,9 +53,7 @@ public final class PaymentMethodsViewModel: PaymentMethodsViewModelType,
         .materialize()
     }
 
-    lazy var paymentSheetEnabled: Bool = {
-      true
-    }()
+    let paymentSheetEnabled: Bool = true
 
     let deletePaymentMethodEvents = self.didDeleteCreditCardSignal
       .map(first)

diff --git a/Library/ViewModels/PledgePaymentMethodsViewModel.swift b/Library/ViewModels/PledgePaymentMethodsViewModel.swift
@@ -72,9 +72,7 @@ public final class PledgePaymentMethodsViewModel: PledgePaymentMethodsViewModelT
     let context = configureWithValue.map { $0.context }
     let availableCardTypes = project.map { $0.availableCardTypes }.skipNil()
 
-    lazy var paymentSheetEnabled: Bool = {
-      true
-    }()
+    let paymentSheetEnabled: Bool = true
 
     let storedCardsEvent = configureWithValue
       .switchMap { _ in

diff --git a/Library/ViewModels/PledgePaymentMethodsViewModelTests.swift b/Library/ViewModels/PledgePaymentMethodsViewModelTests.swift
@@ -894,7 +894,7 @@ final class PledgePaymentMethodsViewModelTests: TestCase {
     }
   }
 
-  func testGoToAddNewStripeCard_WithPaymentSheetEnabled_NoStoredCards_Success() {
+  func testGoToAddNewStripeCard_NoStoredCards_Success() {
     let project = Project.template
     let graphUser = GraphUser.template |> \.storedCards .~ UserCreditCards.withCards([])
     let response = UserEnvelope<GraphUser>(me: graphUser)

diff --git a/Library/ViewModels/ProjectPamphletMainCellViewModel.swift b/Library/ViewModels/ProjectPamphletMainCellViewModel.swift
@@ -281,7 +281,7 @@ public final class ProjectPamphletMainCellViewModel: ProjectPamphletMainCellView
     }
 
     self.campaignTabShown = project.ignoreValues()
-      .map(campaignTabEnabled)
+      .map(value: campaignTabEnabled)
   }
 
   private let awakeFromNibProperty = MutableProperty(())
@@ -412,9 +412,7 @@ private func fundingStatus(forProject project: Project) -> String {
   }
 }
 
-private func campaignTabEnabled() -> Bool {
-  true
-}
+private let campaignTabEnabled: Bool = true
 
 typealias ConvertedCurrrencyProjectData = (pledgedAmount: Int, goalAmount: Int, country: Project.Country)