[No Ticket] Full MockOptimizely Removal PR Fixes/Cleanup

[scottkicks]

📲 What

Regarding my Full MockOptimizely Removal PR
There are some further changes and cleanup that can be done.

🤔 Why

Its important to be thorough in code cleanup, making sure to really understand why certain changes are being made and how best to address removing and/or cleaning up so that we can guarantee that our app is better for it.

🛠 How

• Adding tests around our .ksr_remoteConfigClientConfigured & .ksr_remoteConfigClientConfigurationFailed notifications
• Simplifying properties like paymentSheetEnabled & campaignTabEnabled that were previously updated
• Removing redundant tests
• Removing Snapshots associated with snapshot tests that were removed and making sure only affected snapshots are updated

✅ Acceptance criteria

• all tests pass

⏰ TODO

• Discuss snapshot changes from old PR with Mubarak to get better aligned on why they were so many changes in the first place and how best to approach next steps.

[codecov]

Codecov Report

Merging #1825 (8e9db64) into main (0e92dd6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1825   +/-   ##
=======================================
  Coverage   84.35%   84.36%           
=======================================
  Files        1276     1276           
  Lines      115449   115436   -13     
  Branches    30743    30738    -5     
=======================================
- Hits        97392    97383    -9     
+ Misses      16990    16986    -4     
  Partials     1067     1067           

Impacted Files	Coverage Δ
...ents/Controllers/CommentsViewControllerTests.swift	100.00% <ø> (ø)
Kickstarter-iOS/AppDelegateViewModelTests.swift	98.67% <100.00%> (+0.01%)	⬆️
Library/ViewModels/PaymentMethodsViewModel.swift	98.24% <100.00%> (-0.03%)	⬇️
...ary/ViewModels/PledgePaymentMethodsViewModel.swift	92.58% <100.00%> (-0.04%)	⬇️
...iewModels/PledgePaymentMethodsViewModelTests.swift	97.57% <100.00%> (ø)
.../ViewModels/ProjectPamphletMainCellViewModel.swift	95.87% <100.00%> (-0.04%)	⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[msadoon]

So close to perfect, haha, just remember if we remove a test in a view controller to remove the corresponding screenshots.

[msadoon]

[Assuming tests pass] Update the milestone to 5.9.0 - but don't merge this pr yet. Let's merge the marketing version update for 5.8.0 first, close out milestone 5.8.0 (no action required), update the release branch (main --> release-5.8.0 PR), then merge this in.