[MBL-993] Dark Mode Feature Flag (#1865)

* add new feature flag * add install-rosetta step to deploy_alpha
kickstarter · Oct 11, 2023 · d90d518 · d90d518
1 parent 1475571
commit d90d518
Show file tree

Hide file tree

Showing 7 changed files with 38 additions and 0 deletions.
diff --git a/...teConfigFeatureFlagTools/Controller/RemoteConfigFeatureFlagToolsViewControllerTests.swift b/...teConfigFeatureFlagTools/Controller/RemoteConfigFeatureFlagToolsViewControllerTests.swift
@@ -23,6 +23,7 @@ final class RemoteConfigFeatureFlagToolsViewControllerTests: TestCase {
     let mockRemoteConfigClient = MockRemoteConfigClient()
       |> \.features .~ [
         RemoteConfigFeature.consentManagementDialogEnabled.rawValue: false,
+        RemoteConfigFeature.darkModeEnabled.rawValue: false,
         RemoteConfigFeature.facebookLoginInterstitialEnabled
           .rawValue: false,
         RemoteConfigFeature.reportThisProjectEnabled.rawValue: false

diff --git a/...agToolsViewControllerTests/testRemoteConfigFeatureFlagToolsViewController.1.png b/...agToolsViewControllerTests/testRemoteConfigFeatureFlagToolsViewController.1.png
diff --git a/Library/RemoteConfig/RemoteConfigFeature+Helpers.swift b/Library/RemoteConfig/RemoteConfigFeature+Helpers.swift
@@ -7,6 +7,13 @@ public func featureConsentManagementDialogEnabled() -> Bool {
       .isFeatureEnabled(featureKey: RemoteConfigFeature.consentManagementDialogEnabled) ?? false)
 }
 
+public func featureDarkModeEnabled() -> Bool {
+  return AppEnvironment.current.userDefaults
+    .remoteConfigFeatureFlags[RemoteConfigFeature.darkModeEnabled.rawValue] ??
+    (AppEnvironment.current.remoteConfigClient?
+      .isFeatureEnabled(featureKey: RemoteConfigFeature.darkModeEnabled) ?? false)
+}
+
 public func featureFacebookLoginInterstitialEnabled() -> Bool {
   return AppEnvironment.current.userDefaults
     .remoteConfigFeatureFlags[RemoteConfigFeature.facebookLoginInterstitialEnabled.rawValue] ??

diff --git a/Library/RemoteConfig/RemoteConfigFeature+HelpersTests.swift b/Library/RemoteConfig/RemoteConfigFeature+HelpersTests.swift
@@ -21,6 +21,24 @@ final class RemoteConfigFeatureHelpersTests: TestCase {
     }
   }
 
+  func testDarkMode_RemoteConfig_FeatureFlag_False() {
+    let mockRemoteConfigClient = MockRemoteConfigClient()
+      |> \.features .~ [RemoteConfigFeature.darkModeEnabled.rawValue: false]
+
+    withEnvironment(remoteConfigClient: mockRemoteConfigClient) {
+      XCTAssertFalse(featureDarkModeEnabled())
+    }
+  }
+
+  func testDarkMode_RemoteConfig_FeatureFlag_True() {
+    let mockRemoteConfigClient = MockRemoteConfigClient()
+      |> \.features .~ [RemoteConfigFeature.darkModeEnabled.rawValue: true]
+
+    withEnvironment(remoteConfigClient: mockRemoteConfigClient) {
+      XCTAssertTrue(featureDarkModeEnabled())
+    }
+  }
+
   func testFacebookDeprecation_RemoteConfig_FeatureFlag_True() {
     let mockRemoteConfigClient = MockRemoteConfigClient()
       |> \.features .~ [RemoteConfigFeature.facebookLoginInterstitialEnabled.rawValue: true]

diff --git a/Library/RemoteConfig/RemoteConfigFeature.swift b/Library/RemoteConfig/RemoteConfigFeature.swift
@@ -2,6 +2,7 @@ import Foundation
 
 public enum RemoteConfigFeature: String, CaseIterable {
   case consentManagementDialogEnabled = "consent_management_dialog"
+  case darkModeEnabled = "dark_mode"
   case facebookLoginInterstitialEnabled = "facebook_interstitial"
   case reportThisProjectEnabled = "report_this_project"
   case useOfAIProjectTab = "use_of_ai_project_tab"
@@ -11,6 +12,7 @@ extension RemoteConfigFeature: CustomStringConvertible {
   public var description: String {
     switch self {
     case .consentManagementDialogEnabled: return "Consent Management Dialog"
+    case .darkModeEnabled: return "Dark Mode"
     case .facebookLoginInterstitialEnabled: return "Facebook Login Interstitial"
     case .reportThisProjectEnabled: return "Report This Project"
     case .useOfAIProjectTab: return "Use of AI Project Tab"

diff --git a/Library/ViewModels/RemoteConfigFeatureFlagToolsViewModel.swift b/Library/ViewModels/RemoteConfigFeatureFlagToolsViewModel.swift
@@ -87,6 +87,8 @@ private func isFeatureEnabled(_ feature: RemoteConfigFeature) -> Bool {
   switch feature {
   case .consentManagementDialogEnabled:
     return featureConsentManagementDialogEnabled()
+  case .darkModeEnabled:
+    return featureDarkModeEnabled()
   case .facebookLoginInterstitialEnabled:
     return featureFacebookLoginInterstitialEnabled()
   case .reportThisProjectEnabled:
@@ -103,6 +105,9 @@ private func getValueFromUserDefaults(for feature: RemoteConfigFeature) -> Bool?
   case .consentManagementDialogEnabled:
     return AppEnvironment.current.userDefaults
       .remoteConfigFeatureFlags[RemoteConfigFeature.consentManagementDialogEnabled.rawValue]
+  case .darkModeEnabled:
+    return AppEnvironment.current.userDefaults
+      .remoteConfigFeatureFlags[RemoteConfigFeature.darkModeEnabled.rawValue]
   case .facebookLoginInterstitialEnabled:
     return AppEnvironment.current.userDefaults
       .remoteConfigFeatureFlags[RemoteConfigFeature.facebookLoginInterstitialEnabled.rawValue]
@@ -122,6 +127,9 @@ private func setValueInUserDefaults(for feature: RemoteConfigFeature, and value:
   case .consentManagementDialogEnabled:
     AppEnvironment.current.userDefaults
       .remoteConfigFeatureFlags[RemoteConfigFeature.consentManagementDialogEnabled.rawValue] = value
+  case .darkModeEnabled:
+    AppEnvironment.current.userDefaults
+      .remoteConfigFeatureFlags[RemoteConfigFeature.darkModeEnabled.rawValue] = value
   case .facebookLoginInterstitialEnabled:
     return AppEnvironment.current.userDefaults
       .remoteConfigFeatureFlags[RemoteConfigFeature.facebookLoginInterstitialEnabled.rawValue] = value

diff --git a/Library/ViewModels/RemoteConfigFeatureFlagToolsViewModelTests.swift b/Library/ViewModels/RemoteConfigFeatureFlagToolsViewModelTests.swift
@@ -23,6 +23,7 @@ final class RemoteConfigFlagToolsViewModelTests: TestCase {
     let mockRemoteConfigClient = MockRemoteConfigClient()
       |> \.features .~ [
         RemoteConfigFeature.consentManagementDialogEnabled.rawValue: true,
+        RemoteConfigFeature.darkModeEnabled.rawValue: true,
         RemoteConfigFeature.facebookLoginInterstitialEnabled.rawValue: true,
         RemoteConfigFeature.reportThisProjectEnabled.rawValue: true,
         RemoteConfigFeature.useOfAIProjectTab.rawValue: true
@@ -45,6 +46,7 @@ final class RemoteConfigFlagToolsViewModelTests: TestCase {
     let mockRemoteConfigClient = MockRemoteConfigClient()
       |> \.features .~ [
         RemoteConfigFeature.consentManagementDialogEnabled.rawValue: true,
+        RemoteConfigFeature.darkModeEnabled.rawValue: false,
         RemoteConfigFeature.facebookLoginInterstitialEnabled.rawValue: true,
         RemoteConfigFeature.reportThisProjectEnabled.rawValue: false,
         RemoteConfigFeature.useOfAIProjectTab.rawValue: false