Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-993] Dark Mode Feature Flag #1865

Merged
merged 3 commits into from Oct 11, 2023
Merged

Conversation

scottkicks
Copy link
Contributor

@scottkicks scottkicks commented Oct 11, 2023

πŸ“² What

A new Feature Flag for the Dark Mode

πŸ€” Why

Having a safeguard for implementing dark mode allows us to more confidently release and rollout this feature.

πŸ›  How

  • Updated RemoteConfigFeatures, RemoteConfigFeature+Helpers, RemoteConfigFeatureFlagToolsViewModel.
  • Added tests

dark_mode was also added to our Firebase RemoteConfig Dashboard Production, Beta and Alpha apps.

πŸ‘€ See

Trello, screenshots, external resources?

Before πŸ› After πŸ¦‹
Screenshot 2023-09-12 at 11 48 35 AM Screenshot 2023-09-12 at 11 48 45 AM

βœ… Acceptance criteria

  • Feature flag is available for use via the featureDarkModeEnabled() helper method.
  • Feature flag is available in our Firebase RemoteConfig Dashboard
  • Updating the flag from our Firebase dashboard updates the app
  • We can update the app locally. This change persists and takes priority over the firebase dashboard flag value. This is for internal testing.

@scottkicks scottkicks self-assigned this Oct 11, 2023
@scottkicks scottkicks added this to the release-5.11.0 milestone Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #1865 (8692c86) into main (1475571) will decrease coverage by 3.96%.
The diff coverage is 74.07%.

@@            Coverage Diff             @@
##             main    #1865      +/-   ##
==========================================
- Coverage   87.91%   83.95%   -3.96%     
==========================================
  Files         858     1222     +364     
  Lines       76777   111055   +34278     
  Branches    20310    29506    +9196     
==========================================
+ Hits        67501    93241   +25740     
- Misses       8538    16801    +8263     
- Partials      738     1013     +275     
Files Coverage Ξ”
...oteConfigFeatureFlagToolsViewControllerTests.swift 100.00% <100.00%> (ΓΈ)
...emoteConfig/RemoteConfigFeature+HelpersTests.swift 100.00% <100.00%> (ΓΈ)
...s/RemoteConfigFeatureFlagToolsViewModelTests.swift 100.00% <100.00%> (ΓΈ)
...ary/RemoteConfig/RemoteConfigFeature+Helpers.swift 80.00% <80.00%> (ΓΈ)
Library/RemoteConfig/RemoteConfigFeature.swift 0.00% <0.00%> (ΓΈ)
...Models/RemoteConfigFeatureFlagToolsViewModel.swift 69.13% <37.50%> (-3.47%) ⬇️

... and 368 files with indirect coverage changes

πŸ“£ We’re building smart automated test selection to slash your CI/CD build times. Learn more

@scottkicks scottkicks marked this pull request as ready for review October 11, 2023 15:35
Copy link
Contributor

@amy-at-kickstarter amy-at-kickstarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottkicks scottkicks merged commit d90d518 into main Oct 11, 2023
8 checks passed
@scottkicks scottkicks deleted the mbl-993-dark-mode-feature-flag branch October 11, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants