Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds required inputs for Optimizely experiments running on app launch #1091

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

ifbarrera
Copy link
Contributor

📲 What

In order to access experiment variants in the AppDelegateViewModel, we need an input for when the OptimizelyClient has been updated in the AppEnvironment, among other things.

🤔 Why

This PR adds some of that shared functionality that we need on multiple feature branches to reduce duplication of work and merge conflicts.

✅ Acceptance criteria

There are no user-facing changes here, just exposing functions and adding an input to be used on other feature branches.

Copy link
Contributor

@Scollaco Scollaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ifbarrera ifbarrera merged commit 5046584 into master Mar 3, 2020
@ifbarrera ifbarrera deleted the optimizely-shared-improvements branch March 3, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants