Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-885] Landing page optimizely events #1112

Merged
merged 25 commits into from
Mar 19, 2020

Conversation

Scollaco
Copy link
Contributor

📲 What

  • Adds Optimizely events to track when app enters in background and when the Get Started button on the Landing Page is tapped.

🤔 Why

Jira ticket .

🛠 How

  • On the AppDelegateViewModel, added the tracking client to fire whenever applicationDidEnterBackgroundProperty.signal emits.
  • On the LandingPageViewModel, added the tracking client to fire whenever ctaButtonTappedSignal emits.

👀 See

  • N/A

✅ Acceptance criteria

  • Launch the app and put in background. The App Closed event should appear on the logs.

On AppDelegateViewModel, add a return true below the shouldGoToLandingPage function signature. This will force the Landing Page to be presented:
Screenshot 2020-03-18 at 12 19 40

  • Once the Landing Page is presented, tap Get Started button. The Get Started Button Clicked event should appear on the logs.

* Added LandingPageViewController

* Added LandingPageViewModel and assets

* Fixed screen layout

* Added LandingPageViewModelTests

* SwiftFormat

* Fixed comment

* Feedback from Justin and Isabel

* Disabled rotation, feedback from Isabel

* Swiftformat

* Fixed dynamic type support

* SwiftFormat
@Scollaco Scollaco merged commit b3685d3 into master Mar 19, 2020
@Scollaco Scollaco deleted the NT-885-landing-page-optimizely-events branch March 19, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants