[NT-1055] LandingPage deeplink handling bug fix #1146
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fixes a bug where a LandingPage is presented and immediately dismissed if the app is launched through deeplink.
🤔 Why
It's a bug and we don't like bugs.
🛠 How
goToLandingPage
and thedeeplinkActivated
. So in order to solve this, atake(until:)
function was added to prevent thedeeplinkActivated
from emitting ifgoToLandingPage
already emitted.👀 See
✅ Acceptance criteria
In order to test this, follow the steps:
Wait for executable to be launched
1116
, returntrue
immediately after the open bracket:let openUrl = self.applicationOpenUrlProperty.signal
.delay(2, on: AppEnvironment.current.scheduler)
.skipNil()