[NT-735] Sign in with Apple #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature-sign-in-with-apple
…feature-sign-in-with-apple
Generated by 🚫 Danger |
* Adding ProcessingViewPresenting * Adding tests for isLoading behavior * Revert code signing * Adding voice over support * Adding accessibility labels to the logos * Automatic signing
justinswart
approved these changes
May 1, 2020
| if let error = self.signInWithAppleResult?.error { | ||
| return SignalProducer(error: error) | ||
| } | ||
| return SignalProducer(value: self.signInWithAppleResult?.value ?? SignInWithAppleEnvelope.template) |
There was a problem hiding this comment.
I don't really think we should ever return defaults from these things 🤷♂️ but I know it's been done in a couple places.
| @@ -0,0 +1,24 @@ | |||
| import Foundation | |||
|
|
|||
| public struct SignInWithAppleInput: GraphMutationInput { | |||
There was a problem hiding this comment.
If we conform SignInWithAppleInput to Encodable then we don't need the toInputDictionary() function below.
There was a problem hiding this comment.
Done! Also noticed we were missing tests for this, so I added those too.
…feature-sign-in-with-apple # Conflicts: # Kickstarter-iOS/Views/Controllers/PledgeViewController.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Contains the PRs with the Sign In With Apple work
#1131 - Continue with Apple UI
#1152 - (1/2) Sign in with Apple mutation
#1158 - (2/2) Sign in with Apple
#1163 - Sign in with Apple event
#1168 - Add Loader to Login/Signup Page
⏰ TODO
👋
