-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NT-1238] Adding location tag to projects sorted by distance #1186
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -6210,7 +6210,7 @@ | |||
GCC_WARN_UNUSED_FUNCTION = YES; | |||
GCC_WARN_UNUSED_VARIABLE = YES; | |||
IPHONEOS_DEPLOYMENT_TARGET = 12.4; | |||
MARKETING_VERSION = 4.5.1; | |||
MARKETING_VERSION = 4.6.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of mismatched version numbers in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops! reverting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job fixing those layout warnings! Now I'm just seeing one from DiscoveryNavigationHeaderViewController
which I think should be easy enough to silence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
📲 What
Adds the location tag on project cards if projects have been sorted by distance.
🤔 Why
For the Lights On feature, we'd like to show users projects near them. We'll be accomplishing this by using the
.distance
sort on thev1
API. We would also like to show users the location of the project on the project cards if they're seeing projects that are sorted by distance.🛠 How
Adding the location tag was pretty trivial in itself, but positioning it correctly turned out to be difficult given the convoluted and sub-optimal hierarchy of elements in the project cards. I decided to re-organize all the subviews in the project cards into a more manageable and simple heirarchy. This resulted in:
The location tag will only show if the projects have been sorted by distance.
👀 See
Please note that the after screenshot is showing the "You're a backer" and location tags programatically.
♿️ Accessibility
✅ Acceptance criteria
Replace Line 278 in
DiscoveryPostcardViewModel
with the following code to show the location tag: