Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating Optimizely Tracking to the Data Lake #1205

Merged
merged 6 commits into from
May 22, 2020

Conversation

ifbarrera
Copy link
Contributor

📲 What

We are migrating our tracking for Optimizely to the Data Lake. Previously, we would track experiments using the Optimizely SDK, but this is no longer desirable because we want to do more comprehensive analytics using Amplitude. By sending Optimizely tracking events to the Data Lake, we can route them both to the Optimizely API and to Amplitude for analysis.

🛠 How

  • migrated all experiment-related tracking calls to the data lake
  • removed track function from OptimizelyClientType
  • added the Optimizely property group to all events that we plan to send to the Optimizely API

✅ Acceptance criteria

Everything in this branch has already been tested & reviewed.

* Add new optimizely props

* optimizelyProps tests

* Change to “unknown”

* Update test name

* Use fake experiments strings for tests

* Simplyfing allExperiments code
* Add new optimizely props

* optimizelyProps tests

* Change to “unknown”

* Update test name

* Use fake experiments strings for tests

* Add missing whitelisted data lake events

* Add new whitelisted events

* Add carousel swiped event

* Onboarding tracking events & tests

* Remove “App Completed Checkout”

* Updating tests

* Simplyfing allExperiments code

* Tracking tests

* Removing optimizely tracking references

* Cleaning up
* Add new optimizely props

* optimizelyProps tests

* Change to “unknown”

* Update test name

* Use fake experiments strings for tests

* Add missing whitelisted data lake events

* Add new whitelisted events

* Add carousel swiped event

* Onboarding tracking events & tests

* Remove “App Completed Checkout”

* Updating tests

* Simplyfing allExperiments code

* Tracking tests

* Removing optimizely tracking references

* Add optimizely properties to creator details viewed and campaign button clicked

* Add optimizely properties to relevant events

* Formatting

* Cleaning up

* Cleaning up test name

* Coalesce to an empty dictionary for opty props
…feature-optimizely-tracking

# Conflicts:
#	Library/OptimizelyClientType.swift
#	Library/OptimizelyClientTypeTests.swift
Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢

@ifbarrera ifbarrera merged commit 0f36a4b into master May 22, 2020
@ifbarrera ifbarrera deleted the feature-optimizely-tracking branch May 22, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants