[NT-1194] Migrate Optimizely events to send to the Data Lake #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…os-oss into NT-1174-add-opty-to-events
…starter/ios-oss into NT-1194-migrate-opty-events # Conflicts: # Library/OptimizelyClientType.swift
justinswart
reviewed
Apr 28, 2020
| @@ -417,11 +409,11 @@ final class AppDelegateViewModelTests: TestCase { | |||
| XCTAssertEqual(["App Open", "Opened App"], trackingClient.events) | |||
|
|
|||
| self.vm.inputs.applicationDidEnterBackground() | |||
| XCTAssertEqual(["App Open", "Opened App", "App Close", "Closed App"], trackingClient.events) | |||
There was a problem hiding this comment.
Decided to not track App Close anymore?
There was a problem hiding this comment.
Yep, that's right.
Library/Tracking/Koala.swift
Outdated
| @@ -57,11 +64,14 @@ public final class Koala { | |||
| /// Determines the screen from which the event is sent. | |||
| public enum LocationContext: String { | |||
| case activities = "activity_feed_screen" // ActivitiesViewController | |||
| case campaign = "campaign_screen" | |||
There was a problem hiding this comment.
what's the // <view controller> for this one?
| let attributes = optimizelyUserAttributes(refTag: refTag) | ||
|
|
||
| try? AppEnvironment.current.optimizelyClient?.track( | ||
| eventKey: "Editorial Card Clicked", |
There was a problem hiding this comment.
Removed because the campaign is over right?
There was a problem hiding this comment.
This PR removes all events previously tracked on the Optimizely SDK, because those events have been migrated to the data lake. An upcoming PR will add the necessary Optimizely properties to the required events.
|
|
||
| try? AppEnvironment.current.optimizelyClient? | ||
| .track( | ||
| eventKey: "App Completed Checkout", |
There was a problem hiding this comment.
I understood that we still wanted this event.
There was a problem hiding this comment.
Nope, the backend will be sending this.
Generated by 🚫 Danger |
justinswart
approved these changes
Apr 30, 2020
ifbarrera
added a commit
that referenced
this pull request
May 22, 2020
* [NT-1162] Add OptimizelyProperties (#1172) * Add new optimizely props * optimizelyProps tests * Change to “unknown” * Update test name * Use fake experiments strings for tests * Simplyfing allExperiments code * [NT-1194] Migrate Optimizely events to send to the Data Lake (#1177) * Add new optimizely props * optimizelyProps tests * Change to “unknown” * Update test name * Use fake experiments strings for tests * Add missing whitelisted data lake events * Add new whitelisted events * Add carousel swiped event * Onboarding tracking events & tests * Remove “App Completed Checkout” * Updating tests * Simplyfing allExperiments code * Tracking tests * Removing optimizely tracking references * Cleaning up * [NT-1174] Add Optimizely Properties to relevant events (#1180) * Add new optimizely props * optimizelyProps tests * Change to “unknown” * Update test name * Use fake experiments strings for tests * Add missing whitelisted data lake events * Add new whitelisted events * Add carousel swiped event * Onboarding tracking events & tests * Remove “App Completed Checkout” * Updating tests * Simplyfing allExperiments code * Tracking tests * Removing optimizely tracking references * Add optimizely properties to creator details viewed and campaign button clicked * Add optimizely properties to relevant events * Formatting * Cleaning up * Cleaning up test name * Coalesce to an empty dictionary for opty props * Fixing merge conflict issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Migrates some events that were previously being sent to Optimizely via the Optimizely SDK, to be sent instead to the data lake. This will allow us to send events directly to both Optimizely and Amplitude through data lake lambdas.
🤔 Why
In preparation for migrating all our Optimizely events to send from data lake lambdas, we need to make sure that these events are flowing through the data lake. Moving forward, all Optimizely events will flow through the data lake, so we no longer need to track anything through the Optimizely SDK.
🛠 How
trackfunction from theOptimizelyClientTypeprotocoltrackon the Optimizely SDKKoalaclient on theAppEnvironmentNote that adding the necessary Optimizely properties to the event property groups will be done in a follow-up PR.
✅ Acceptance criteria
Test that the follow events are being sent through the Data Lake, instead of through the Optimizely SDK:
context_locationshould belanding_page)context_locationshould beonboarding)context_locationshould beonboarding)