[NT-1299] Apple Sign In Processing View dismissal bugfix #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinswart
commented
May 29, 2020
| @@ -31,6 +31,8 @@ final class LoginToutViewModelTests: TestCase { | |||
| override func setUp() { | |||
| super.setUp() | |||
|
|
|||
| self.vm = LoginToutViewModel() | |||
There was a problem hiding this comment.
In order for the test to pass we needed to create the VM after the scheduler is set in the environment. We've had to do this in a number of places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fixes an bug which caused the processing view to never dismiss after logging in via Apple Sign In from the profile tab.
🤔 Why
A number of things are happening all at once here:
Once the notifications are posted about the user login state having changed our
RootViewModelrecreates all of the VCs and sets them again on the tab bar. This was causing theLoginToutViewControllerto be deallocated before the observing closure could execute and hide the processing view.One way of solving this would be to have another input on the view model to inform of the processing view having been dismissed. Another fairly simple solution is to place the posting of the notifications on the next run loop with a zero nanosecond delay. This PR implements the latter and adds a test.
🛠 How
Imposed a zero nanosecond delay on
LoginToutViewModel'spostNotificationoutput to ensure that it will emit last.✅ Acceptance criteria