Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-1495] Update logic for quantity attributed text in RewardCardView #1308

Merged
merged 4 commits into from
Sep 28, 2020

Conversation

singhhari
Copy link
Contributor

📲 What

When specifying a quantity of add-ons, we use # x add-on name on both the Pledge screen and the View/Manage Pledge screen. On the Pledge screen, we hide # x when # is > 1, but we don’t do that on the View/Manage screen

🤔 Why

Consistency within view controllers that display similar information.

🛠 How

All of the work is done in the RewardCardViewModel. We're doing a check on the quantity of the add-on which was updated.

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #1308 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1308   +/-   ##
=======================================
  Coverage   85.70%   85.70%           
=======================================
  Files        1109     1109           
  Lines       96870    96882   +12     
=======================================
+ Hits        83022    83035   +13     
+ Misses      13848    13847    -1     
Impacted Files Coverage Δ
Library/ViewModels/RewardCardViewModel.swift 95.23% <100.00%> (+0.59%) ⬆️
Library/ViewModels/RewardCardViewModelTests.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bbb921...40c11c6. Read the comment docs.

Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks good - can we add a test to be sure? 🙂

@singhhari singhhari merged commit aacc37f into master Sep 28, 2020
@singhhari singhhari deleted the NT-1495-hide-quantity-x-on-addon-cards branch September 28, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants