Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-1565] Backers Can Edit an Expired Reward with Add-Ons #1313

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

justinswart
Copy link
Contributor

📲 What

Allows backers to edit an expired reward with add-ons.

🤔 Why

Fixes a bug from #1309. Rewards should be editable if they've expired and have add-ons.

🛠 How

Fixed the logic for this and added tests.

👀 See

✅ Acceptance criteria

  • Back a reward with add-ons that will expire soon. Once it has expired you should be able to edit it.
  • There should be no regressions to other reward editing behaviour (see tests).

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #1313 into master will increase coverage by 13.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1313       +/-   ##
===========================================
+ Coverage   72.23%   85.74%   +13.50%     
===========================================
  Files         608     1109      +501     
  Lines       40389    97135    +56746     
===========================================
+ Hits        29175    83288    +54113     
- Misses      11214    13847     +2633     
Impacted Files Coverage Δ
Library/SharedFunctions.swift 83.70% <100.00%> (ø)
Library/SharedFunctionsTests.swift 100.00% <100.00%> (ø)
...rary/ViewModels/RewardCardContainerViewModel.swift 91.35% <100.00%> (ø)
Library/ViewModels/RewardCardViewModel.swift 95.20% <100.00%> (ø)
...ibrary/ViewModels/RewardsCollectionViewModel.swift 99.42% <100.00%> (ø)
...y/ViewModels/RewardsCollectionViewModelTests.swift 100.00% <100.00%> (ø)
...y/ViewModels/ProjectActivitiesViewModelTests.swift 100.00% <0.00%> (ø)
Library/UpdateActivityItemProviderTests.swift 100.00% <0.00%> (ø)
Library/ViewModels/WebModalViewModelTests.swift 100.00% <0.00%> (ø)
Library/Instantiable.swift 100.00% <0.00%> (ø)
... and 502 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8844e4b...ecf2514. Read the comment docs.

Copy link
Contributor

@singhhari singhhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@justinswart justinswart merged commit 7b1f2c8 into master Oct 2, 2020
@justinswart justinswart deleted the NT-1565-edit-timed-out-rewards branch October 2, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants