Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAY-2021] Error Backing Payment Card Being Unselected #1748

Merged
merged 5 commits into from Oct 13, 2022

Conversation

msadoon
Copy link
Contributor

@msadoon msadoon commented Oct 13, 2022

πŸ“² What

A bug was found with adding a new payment sheet card on an errored backing, it wasn't being auto-selected. The previous flow did auto-select it.

πŸ€” Why

Preserve existing functionality with add new payment cards, even with errored backings.

πŸ›  How

Removed the conditional logic to deselect the newest payment sheet card if the backing was errorred.

πŸ‘€ See

Before πŸ›

RPReplay_Final1665601977.MP4

After πŸ¦‹

...coming...

βœ… Acceptance criteria

  • Adding a payment sheet card to an errored backing selects that card.

⏰ TODO

  • Test on device and write unit test.

@msadoon msadoon added the WIP label Oct 13, 2022
@msadoon msadoon added this to the release-5.6.0 milestone Oct 13, 2022
@msadoon msadoon self-assigned this Oct 13, 2022
@msadoon msadoon marked this pull request as ready for review October 13, 2022 17:14
@msadoon msadoon added needs review and removed WIP labels Oct 13, 2022
@msadoon msadoon requested review from scottkicks and a team October 13, 2022 17:18
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #1748 (729f2d4) into main (d382b78) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1748   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files        1275     1275           
  Lines      115196   115181   -15     
  Branches    30456    30453    -3     
=======================================
- Hits        98362    98352   -10     
+ Misses      15781    15776    -5     
  Partials     1053     1053           
Impacted Files Coverage Ξ”
...ary/ViewModels/PledgePaymentMethodsViewModel.swift 97.83% <100.00%> (+1.22%) ⬆️
...iewModels/PledgePaymentMethodsViewModelTests.swift 98.07% <100.00%> (-0.01%) ⬇️

πŸ“£ We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@scottkicks scottkicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘πŸ»

@msadoon msadoon merged commit 63e5d5e into main Oct 13, 2022
@msadoon msadoon deleted the feature/errorred-backing-flow-card-selection branch October 13, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants