New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTV-612: Move Minimum Version Up To iOS 14 #1751
Conversation
@@ -79,7 +79,6 @@ extension User { | |||
var followerNotification: Bool? | |||
var friendActivityNotification: Bool? | |||
var messagesNotification: Bool? | |||
var postLikesNotification: Bool? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing unused property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea leave this in, not iOS 14 related, when I created these models I left properties that might later get included in the GQL layer. It's good to know they are there as they indicate what v1 supported, and there are more of them.
Kickstarter-iOS/Features/ThanksProjects/Controller/ThanksViewController.swift
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1751 +/- ##
=======================================
Coverage 85.38% 85.38%
=======================================
Files 1275 1275
Lines 115181 115183 +2
Branches 30454 30455 +1
=======================================
+ Hits 98350 98352 +2
+ Misses 15778 15777 -1
- Partials 1053 1054 +1
π£ Weβre building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just make a few changes as suggested.
@@ -124,7 +124,7 @@ private func shippingRulesData( | |||
|
|||
return ShippingRule.shippingRule(from: fragment) | |||
} | |||
.flatMap { $0 } | |||
.compactMap { $0 } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave this in, there are other deprecated warnings of using .flatMap
where we can use .compactMap
in the model layer, but more investigation needs to be done as to why we're using compactMap
and then again compactMap
the same collection. Seems like we need flatMap
to further reduce the number of levels in the collection.
@@ -79,7 +79,6 @@ extension User { | |||
var followerNotification: Bool? | |||
var friendActivityNotification: Bool? | |||
var messagesNotification: Bool? | |||
var postLikesNotification: Bool? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea leave this in, not iOS 14 related, when I created these models I left properties that might later get included in the GQL layer. It's good to know they are there as they indicate what v1 supported, and there are more of them.
Kickstarter-iOS/Features/ThanksProjects/Controller/ThanksViewController.swift
Outdated
Show resolved
Hide resolved
just wait until tests pass and clean up the formatting then merge |
π² What
Updates minimum iOS deployment target to 14.0.
π€ Why
With the release of iOS 16, let's keep our usual support of two minimum versions back on iOS.
π How
β Acceptance criteria
Notes
In the last calendar year we've had:
So, we shouldn't see any users being dropped from this update.
see our firebase console for more current data points.