Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTV-612: Move Minimum Version Up To iOS 14 #1751

Merged
merged 4 commits into from
Oct 27, 2022
Merged

NTV-612: Move Minimum Version Up To iOS 14 #1751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8e990c3
set minimum ios version to 14.0
Oct 25, 2022
0f81f23
address deprecation warnings
Oct 25, 2022
7ce3645
feedback
Oct 26, 2022
763105a
formatting
Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Kickstarter-iOS/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ extension AppDelegate: UNUserNotificationCenterDelegate {
withCompletionHandler completionHandler: @escaping (UNNotificationPresentationOptions) -> Void
) {
self.rootTabBarController?.didReceiveBadgeValue(notification.request.content.badge as? Int)
completionHandler(.alert)
completionHandler([.banner, .list])
msadoon marked this conversation as resolved.
Show resolved Hide resolved
}

func userNotificationCenter(
Expand Down
5 changes: 4 additions & 1 deletion Kickstarter-iOS/Features/ThanksProjects/Controller/ThanksViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,10 @@ internal final class ThanksViewController: UIViewController, UITableViewDelegate
}

fileprivate func showRatingAlert() {
SKStoreReviewController.requestReview()
if let scene = UIApplication.shared.connectedScenes
.first(where: { $0.activationState == .foregroundActive }) as? UIWindowScene {
SKStoreReviewController.requestReview(in: scene)
}
}

fileprivate func showGamesNewsletterAlert() {
Expand Down
8 changes: 4 additions & 4 deletions Kickstarter.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9215,7 +9215,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 13.6;
IPHONEOS_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = 5.5.0;
MTL_ENABLE_DEBUG_INFO = NO;
OTHER_LDFLAGS = "-ObjC";
Expand Down Expand Up @@ -9672,7 +9672,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 13.6;
IPHONEOS_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = 5.5.0;
MTL_ENABLE_DEBUG_INFO = YES;
ONLY_ACTIVE_ARCH = YES;
Expand Down Expand Up @@ -9741,7 +9741,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 13.6;
IPHONEOS_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = 5.5.0;
MTL_ENABLE_DEBUG_INFO = NO;
OTHER_LDFLAGS = "-ObjC";
Expand Down Expand Up @@ -9995,7 +9995,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 13.6;
IPHONEOS_DEPLOYMENT_TARGET = 14.0;
MARKETING_VERSION = 5.5.0;
MTL_ENABLE_DEBUG_INFO = NO;
OTHER_LDFLAGS = "-ObjC";
Expand Down