Circleci/pipeline queue #1778
Merged
Circleci/pipeline queue #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add new Consent Management Dialog feature flag * Add new Consent Management Dialog feature flag * remove failing view controller test assertion * formatting * Adding a small commit so tests pass on CI. Didn't realize that if we removed the feature from the mock client, the recording would would still have it in the snapshot and our old snapshot wouldn't have been updated yet. * formatting Co-authored-by: Mubarak Sadoon <msadoon@gmail.com>
* remove ResetYourFacebookPasswordViewController snapshots * rename viewmodel and viewcontroller * viewmodel form logic suggestions * update viewmodel tests * ensure the scrollview is not hidden by the keyboard * set returnKeyType to go and make api call on tap * update accessibility on set your password view controller * updated accessibility for facebookresetpasswordviewcontroller. * formatting Co-authored-by: Mubarak Sadoon <msadoon@gmail.com>
* add facebook conversions api feature flag * add facebook conversions api feature flag * fix test
* set NSUserTrackingUsageDescription in plist * request ATTrackingAuthorization on app applicationdidFinishLaunching * formatting * gate behind consent management dialog feature flag * pr feedback * ATTrackingAuthorizationStatus to its own file * Use `.ksr_debounce` on Signal instead of `asyncAfter` * Handle `restricted` and `@unknown` requestTrackingAuthorization status cases * Improve unit test * use ksr_delay insted of ksr_debounce
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## main #1778 +/- ##
==========================================
- Coverage 85.29% 85.24% -0.06%
==========================================
Files 1276 1276
Lines 116541 116682 +141
Branches 30722 30779 +57
==========================================
+ Hits 99408 99462 +54
- Misses 16066 16146 +80
- Partials 1067 1074 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
msadoon
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
All this looks good to me, it's been reviewed already so I just glanced at it.
You own the Facebook and ATT stuff. (Including enabling/disabling feature flags).
So to me this means once that code gets into production, you'll be responsible for it and any bugs/potential changes including turning on/off feature flags that arise.
Let's do rolling releases for the time being.
I usually keep an eye on Firebase Crashlytics to monitor new releases. Our crash-free rate should stay above 99% on 90+ day timeline.
Just my two cents, always let me know your thoughts on processes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Now that our circleci checks are back up and running, let's merge the work we've been doing into
main🤔 Why
We didn't want those issues to halt development so we merged our work into this
circleci/pipeline-queuebranch.✅ Acceptance criteria