Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circleci/pipeline queue #1778

Merged
merged 6 commits into from
Jan 24, 2023
Merged

Circleci/pipeline queue #1778

merged 6 commits into from
Jan 24, 2023

Commits on Jan 17, 2023

  1. [WEB-861] Consent Management feature flag (#1764)

    * Add new Consent Management Dialog feature flag
    
    * Add new Consent Management Dialog feature flag
    
    * remove failing view controller test assertion
    
    * formatting
    
    * Adding a small commit so tests pass on CI.
    
    Didn't realize that if we removed the feature from the mock client, the recording would would still have it in the snapshot and our old snapshot wouldn't have been updated yet.
    
    * formatting
    
    Co-authored-by: Mubarak Sadoon <msadoon@gmail.com>
    scottkicks and msadoon committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    dd9a5b2 View commit details
    Browse the repository at this point in the history
  2. [WEB-696] FacebookResetPassword Improvements (#1765)

    * remove ResetYourFacebookPasswordViewController snapshots
    
    * rename viewmodel and viewcontroller
    
    * viewmodel form logic suggestions
    
    * update viewmodel tests
    
    * ensure the scrollview is not hidden by the keyboard
    
    * set returnKeyType to go and make api call on tap
    
    * update accessibility on set your password view controller
    
    * updated accessibility for facebookresetpasswordviewcontroller.
    
    * formatting
    
    Co-authored-by: Mubarak Sadoon <msadoon@gmail.com>
    scottkicks and msadoon committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    a1857a4 View commit details
    Browse the repository at this point in the history
  3. [WEB-669] Facebook Conversions API Feature Flag (#1766)

    * add facebook conversions api feature flag
    
    * add facebook conversions api feature flag
    
    * fix test
    scottkicks committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    77e4fc7 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. [WEB-862] AppTrackingTransparency Authorization (#1772)

    * set NSUserTrackingUsageDescription in plist
    
    * request ATTrackingAuthorization on app applicationdidFinishLaunching
    
    * formatting
    
    * gate behind consent management dialog feature flag
    
    * pr feedback
    * ATTrackingAuthorizationStatus to its own file
    * Use `.ksr_debounce` on Signal instead of `asyncAfter`
    * Handle `restricted` and `@unknown` requestTrackingAuthorization status cases
    * Improve unit test
    
    * use ksr_delay insted of ksr_debounce
    scottkicks committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    6e900b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d8e4141 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Configuration menu
    Copy the full SHA
    49be635 View commit details
    Browse the repository at this point in the history