[MBL-670] Saved Prelaunch Projects on Backer Dashboard -- Merge After MBL-671 #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew gql call is useful keeping track of saved projects.
|
@scottkicks Again just making you aware this is being merged without review for release timeline purposes. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Trying to get the saved/unsaved prelaunch projects to update the backer dashboard's
Savedcount and project list.🤔 Why
There was a bug on v1 when fetching the user to update the saved projects, a prelaunch project is not counted. GQL fetch user calls doesn't have this bug, so we swapped the call in this instance to GQL.
🛠 How
We didn't create a new adapter or anything we just used the existing
User.user(from: UserFragment) -> User?static function to send back anUserEnvelope<User>instead of the `UserEnvelope from a new call.It's kind of surface level change because its' reusing the old adapter and query to map to a
Userinstead of aGraphUser.👀 See
Before 🐛
Simulator.Screen.Recording.-.iPhone.8.-.2023-03-27.at.11.03.33.mp4
After 🦋
Simulator.Screen.Recording.-.iPhone.8.-.2023-03-27.at.10.58.30.mp4
✅ Acceptance criteria