[Unticketed] Rollback Dashboard Changes for Prelaunch Pages #1811
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Our QA party revealed to us that Dashboard tab was being shown on mobile when it previously wasn't there for users that were "draft" creators. Context.
These PR's are being reversed:
#1805
#1807
This is due to a difference in the way v1 and GQL handle the idea of a "creator" when a project is not live. More detail below.
🤔 Why
This is an issue because a lot of users still have the creator side on the web and we shouldn't introduce a broken experience on mobile (ie. dashboard tab when previously there was none). Wrong approach anyway because we just need to handle the saved tab project list and count not update the user.
🛠 How
https://kickstarter.atlassian.net/wiki/spaces/~294637594/pages/2294120449/Prelaunch+Pages+on+iOS#Resources
Goes into more detail about the differences between v1 and GQL properties ie. how a member of a project is defined.
One of the biggest issues is that GQL "draft" project members are considered "true" if they are invited before the project is launched and "false" in v1.
This is also the wrong approach because we don't need to update the
User
. All we need to do is update the list of "Saved Projects". This isolates any new GQL query to the tab itself. That will be addressed in the ticket above.❌ Breaking Change
This will introduce one regression instead of the UI break. That is - dashboards saved tab will NOT properly reflect the saved states of prelaunch projects for any type of user (creator with published projects, creator with draft projects, backer (no created projects) or collaborator (accepted invited member to a project)).
All users should still be able to save launched projects and see their dashboards updated accurately.
Hoping we can launch this build with this incomplete functionality and patch quickly after just so we can hit our Optimizely removal deadline in a few days.
✅ Acceptance criteria
⏰ Developer QA