[MBL-696] Cleanup Optimizely Experiments

Library/KeyValueStoreType.swift

@@ -7,7 +7,6 @@ public enum AppKeys: String {
   case deniedNotificationContexts = "com.kickstarter.KeyValueStoreType.deniedNotificationContexts"
   case favoriteCategoryIds = "favorite_category_ids"
   case hasCompletedCategoryPersonalizationFlow = "com.kickstarter.KeyValueStoreType.hasCompletedCategoryPersonalizationFlow"
-  case hasSeenCategoryPersonalizationFlow = "com.kickstarter.KeyValueStoreType.hasSeenCategoryPersonalizationFlow"
   case hasDismissedPersonalizationCard = "com.kickstarter.KeyValueStoreType.hasDismissedPersonalizationCard"
   case hasSeenFavoriteCategoryAlert = "com.kickstarter.KeyValueStoreType.hasSeenFavoriteCategoryAlert"
   case hasSeenSaveProjectAlert = "com.kickstarter.KeyValueStoreType.hasSeenSaveProjectAlert"
@@ -40,7 +39,6 @@ public protocol KeyValueStoreType: AnyObject {
   var hasCompletedCategoryPersonalizationFlow: Bool { get set }
   var hasDismissedPersonalizationCard: Bool { get set }
   var hasSeenAppRating: Bool { get set }
-  var hasSeenCategoryPersonalizationFlow: Bool { get set }
   var hasSeenFavoriteCategoryAlert: Bool { get set }
   var hasSeenGamesNewsletterPrompt: Bool { get set }
   var hasSeenSaveProjectAlert: Bool { get set }
@@ -68,15 +66,6 @@ extension KeyValueStoreType {
     }
   }
 
-  public var hasSeenCategoryPersonalizationFlow: Bool {
-    get {
-      return self.bool(forKey: AppKeys.hasSeenCategoryPersonalizationFlow.rawValue)
-    }
-    set {
-      self.set(newValue, forKey: AppKeys.hasSeenCategoryPersonalizationFlow.rawValue)
-    }
-  }
-
   public var hasDismissedPersonalizationCard: Bool {
     get {
       return self.bool(forKey: AppKeys.hasDismissedPersonalizationCard.rawValue)

Library/ViewModels/LandingViewModel.swift

@@ -17,10 +17,6 @@ public protocol LandingViewModelType {
 
 public final class LandingViewModel: LandingViewModelType, LandingViewModelInputs, LandingViewModelOutputs {
   public init() {
-    self.viewDidLoadProperty.signal.observeValues {
-      AppEnvironment.current.userDefaults.hasSeenCategoryPersonalizationFlow = true
-    }
-
     self.goToCategorySelection = self.getStartedButtonTappedProperty.signal
   }
 

Library/ViewModels/LandingViewModelTests.swift

@@ -26,16 +26,4 @@ final class LandingViewModelTests: TestCase {
 
     self.goToCategorySelection.assertValueCount(1)
   }
-
-  func testHasSeenCategoryPersonalizationFlowPropertyIsSet() {
-    let mockKVStore = MockKeyValueStore()
-
-    withEnvironment(userDefaults: mockKVStore) {
-      self.vm.inputs.viewDidLoad()
-
-      self.scheduler.run()
-
-      XCTAssertTrue(mockKVStore.hasSeenCategoryPersonalizationFlow)
-    }
-  }
 }