New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MBL-774] Use Cleaner Remote Config FetchAndActivate Approach #1819
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1819 +/- ##
==========================================
- Coverage 84.46% 84.45% -0.01%
==========================================
Files 1283 1283
Lines 116641 116650 +9
Branches 30947 30953 +6
==========================================
+ Hits 98516 98521 +5
- Misses 17047 17052 +5
+ Partials 1078 1077 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kickstarter.xcodeproj/xcshareddata/xcschemes/Kickstarter-iOS.xcscheme
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to go!
📲 What
🤔 Why
Our implementation now activates previously cached values before fetching. This causes the newly fetched values to be cached for the next launch instead of being applied immediately.
🛠 How
Lets add the fetchAndComplete type signature to
RemoteConfigClientType
Then, we can replace the .fetch and .activate calls.