Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No Ticket] Full MockOptimizely Removal PR Fixes/Cleanup #1825

Merged
merged 8 commits into from
Jun 12, 2023

Merge branch 'main' into scott/optimizely-removal-fixes

8e9db64
Select commit
Failed to load commit list.
Merged

[No Ticket] Full MockOptimizely Removal PR Fixes/Cleanup #1825

Merge branch 'main' into scott/optimizely-removal-fixes
8e9db64
Select commit
Failed to load commit list.
Codecov / codecov/project succeeded Jun 12, 2023 in 0s

84.36% (+0.00%) compared to 0e92dd6

View this Pull Request on Codecov

84.36% (+0.00%) compared to 0e92dd6

Details

Codecov Report

Merging #1825 (8e9db64) into main (0e92dd6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1825   +/-   ##
=======================================
  Coverage   84.35%   84.36%           
=======================================
  Files        1276     1276           
  Lines      115449   115436   -13     
  Branches    30743    30738    -5     
=======================================
- Hits        97392    97383    -9     
+ Misses      16990    16986    -4     
  Partials     1067     1067           
Impacted Files Coverage Δ
...ents/Controllers/CommentsViewControllerTests.swift 100.00% <ø> (ø)
Kickstarter-iOS/AppDelegateViewModelTests.swift 98.67% <100.00%> (+0.01%) ⬆️
Library/ViewModels/PaymentMethodsViewModel.swift 98.24% <100.00%> (-0.03%) ⬇️
...ary/ViewModels/PledgePaymentMethodsViewModel.swift 92.58% <100.00%> (-0.04%) ⬇️
...iewModels/PledgePaymentMethodsViewModelTests.swift 97.57% <100.00%> (ø)
.../ViewModels/ProjectPamphletMainCellViewModel.swift 95.87% <100.00%> (-0.04%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more