[MBL-983] Already Reported Project Label #1857
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| import Library | ||
| import Prelude | ||
| import SwiftUI | ||
| import UIKit | ||
|
|
||
| internal final class ReportProjectCell: UITableViewCell, ValueCell { | ||
| internal func configureWith(value projectFlagged: Bool) { | ||
| self.setupTableViewCellStyle(projectFlagged: projectFlagged) | ||
| self.setupReportProjectLabelView(projectFlagged: projectFlagged) | ||
| } | ||
|
|
||
| internal override func layoutSubviews() { | ||
| super.layoutSubviews() | ||
| } | ||
|
|
||
| internal override func bindStyles() { | ||
| super.bindStyles() | ||
|
|
||
| self.separatorInset = UIEdgeInsets(top: 0, left: 0, bottom: 0, right: .greatestFiniteMagnitude) | ||
| self.setNeedsLayout() | ||
| } | ||
|
|
||
| // MARK: - Private Methods | ||
|
|
||
| private func setupTableViewCellStyle(projectFlagged: Bool) { | ||
| let accessibilityTraits = projectFlagged | ||
| ? UIAccessibilityTraits.staticText | ||
| : UIAccessibilityTraits.button | ||
|
|
||
| _ = self | ||
| |> baseTableViewCellStyle() | ||
| |> ReportProjectCell.lens.accessibilityTraits .~ accessibilityTraits | ||
|
Comment on lines
+26
to
+32
There was a problem hiding this comment. Thanks for adding this! Unfortunately, I don't think it does anything currently; we'd need to also set There was a problem hiding this comment. oh, good callout! I'll look into this in the next PR |
||
| } | ||
|
|
||
| private func setupReportProjectLabelView(projectFlagged: Bool) { | ||
| if #available(iOS 15.0, *) { | ||
| DispatchQueue.main.async { | ||
| let hostingController = | ||
| UIHostingController(rootView: ReportProjectLabelView(flagged: projectFlagged)) | ||
|
|
||
| hostingController.view.translatesAutoresizingMaskIntoConstraints = false | ||
| hostingController.view.backgroundColor = .clear | ||
|
|
||
| self.contentView.addSubview(hostingController.view) | ||
|
|
||
| let leftRightInset = self.traitCollection.isRegularRegular ? Styles.grid(16) : Styles.gridHalf(5) | ||
|
|
||
| NSLayoutConstraint.activate([ | ||
| hostingController.view.topAnchor | ||
| .constraint(equalTo: self.contentView.topAnchor, constant: Styles.gridHalf(5)), | ||
| hostingController.view.bottomAnchor | ||
| .constraint(equalTo: self.contentView.bottomAnchor, constant: -Styles.gridHalf(5)), | ||
| hostingController.view.leadingAnchor | ||
| .constraint(equalTo: self.contentView.leadingAnchor, constant: leftRightInset), | ||
| hostingController.view.trailingAnchor | ||
| .constraint(equalTo: self.contentView.trailingAnchor, constant: -leftRightInset) | ||
| ]) | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| import Library | ||
| import SwiftUI | ||
|
|
||
| @available(iOS 15.0, *) | ||
| struct ReportProjectLabelView: View { | ||
| let flagged: Bool | ||
|
|
||
| @SwiftUI.Environment(\.horizontalSizeClass) private var horizontalSizeClass | ||
|
|
||
| var body: some View { | ||
| if flagged { | ||
| AlreadyReportedView() | ||
| } else { | ||
| HStack { | ||
| Text(Strings.Report_this_project_to()) | ||
| .font(Font(UIFont.ksr_body(size: 14))) | ||
| .foregroundColor(Color(.ksr_support_700)) | ||
|
|
||
| Spacer() | ||
|
|
||
| Image("chevron-right") | ||
| .resizable() | ||
| .scaledToFit() | ||
| .frame(width: 10, height: 10) | ||
| } | ||
| .padding(self.horizontalSizeClass == .regular ? 0 : 10) | ||
| } | ||
| } | ||
|
|
||
| private struct AlreadyReportedView: View { | ||
| var body: some View { | ||
| HStack(alignment: .top, spacing: 10) { | ||
| Image("info") | ||
| .resizable() | ||
| .scaledToFit() | ||
| .frame(width: 20, height: 20) | ||
| .foregroundColor(Color(.ksr_support_500)) | ||
|
|
||
| Text( | ||
| html: Strings.It_looks( | ||
| our_rules: HelpType.prohibitedItems | ||
scottkicks marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| .url(withBaseUrl: AppEnvironment.current.apiService.serverConfig.webBaseUrl)? | ||
| .absoluteString ?? "", | ||
| community_guidelines: HelpType.community | ||
| .url(withBaseUrl: AppEnvironment.current.apiService.serverConfig.webBaseUrl)? | ||
| .absoluteString ?? "" | ||
| ), | ||
| with: [ | ||
| ReportProjectHyperLinkType.ourRules.stringLiteral(), | ||
| ReportProjectHyperLinkType.communityGuidelines.stringLiteral() | ||
| ] | ||
| ) | ||
| .font(Font(UIFont.ksr_caption1())) | ||
| } | ||
| .padding() | ||
| .background(Color(.ksr_support_100)) | ||
| .cornerRadius(15) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @available(iOS 15.0, *) | ||
| struct ReportProjectView_Previews: PreviewProvider { | ||
| static var previews: some View { | ||
| ReportProjectLabelView(flagged: false) | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this cell is still clickable, even when it's already flagged. I'm not 100% sure, since I just overwrote the
flaggedbool locally to test this (instead of contacting team A to get myself added to the flagged list). Will you double check and make the cell non-interactive if needed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double checked and the "already reported" label is never tappable. Only when flagged is false do we show the tappable "report this project" label