[MBL-983] Already Reported Project Label #1857

scottkicks · 2023-09-23T22:57:34Z

📲 What

Replace the "Report this project to Kickstarter" cell with a SwiftUI view that dynamically shows either the original label or a label informing the user that they've already reported the project.

🤔 Why

If a user has already reported a project there's no need to do it again.

🛠 How

Instead of adding a label to the ProjectPamphletSubpage, we can build the new labels with SwiftUI and add it as its own section to the project page's table view datasource. Giving us more control and more SwiftUI.

Uses the new flagging property on Projects to conditionally render the labels.
The new "Already reported" label should not be tappable and include 2 hyperlinks.

Followed Android's implementation as a design reference.

👀 See

iPad	iPhone

✅ Acceptance criteria

You'll need to ask someone on web team A to add your staging account email to the project "Undercover:: The cover art of underglow comics - 200+ pages". This is a test project that has been marked as flagged, but you'll still need it associated with your account so that you see the "Already reported" label.

Also, I didn't choose which project to test with so sorry if that projects cover art is a bit saucy.

Otherwise, any other project will show the "Report this project" label as normal

* UITableView cell will be added to the Project Page Table View * Used to display a new swiftui view for the report this project label and already reported label

ReportProjectLabelView (SwiftUI View) re-renders when its text labels contain hyperlinks. Since we're rendering hyperlinks with the helper in Text+HTML.swift, this seems to cause a `precondition failure: cyclic graph` crash. This check prevents that by making sure the cell is only configured once on dequeue.

needs to be called because we're adding a SwiftUI view to the cell's contentView

… so we know which label can be tappable

we don't need to hide it now that there is a new section below it.

…ickstarter/ios-oss into mbl-983-already-reported-label

codecov · 2023-09-25T17:28:49Z

Codecov Report

Merging #1857 (b38f921) into main (70dc8b3) will decrease coverage by 0.04%.
The diff coverage is 56.92%.

@@            Coverage Diff             @@
##             main    #1857      +/-   ##
==========================================
- Coverage   83.98%   83.95%   -0.04%     
==========================================
  Files        1287     1289       +2     
  Lines      117044   117118      +74     
  Branches    31129    31158      +29     
==========================================
+ Hits        98302    98327      +25     
- Misses      17655    17702      +47     
- Partials     1087     1089       +2

Files	Coverage Δ
...rce/ProjectPageViewControllerDataSourceTests.swift	`97.44% <100.00%> (-0.03%)`	⬇️
Library/HelpType.swift	`87.67% <100.00%> (ø)`
Library/ViewModels/ProjectPageViewModelTests.swift	`98.16% <100.00%> (+<0.01%)`	⬆️
...ewModels/ProjectPamphletSubpageCellViewModel.swift	`73.43% <100.00%> (-5.67%)`	⬇️
...tasource/ProjectPageViewControllerDataSource.swift	`83.79% <87.50%> (-0.10%)`	⬇️
...es/ProjectPage/Views/Cells/ReportProjectCell.swift	`97.14% <97.14%> (ø)`
Library/ViewModels/ProjectPageViewModel.swift	`97.04% <0.00%> (-0.27%)`	⬇️
...Features/ReportProject/ReportProjectInfoView.swift	`0.00% <0.00%> (ø)`
...ectPage/Controller/ProjectPageViewController.swift	`50.30% <50.00%> (+0.23%)`	⬆️
Library/SwiftUI+Extensions/Text+HTML.swift	`0.00% <0.00%> (ø)`
... and 1 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ifosli

Generally looks good, though I have some concerns. See comments. Also, a11y for this cell needs to be updated as well (mark ReportProjectCell as an a11y element and as a button, at least when it's not flagged) but I can fold that in to the other a11y things if you'd prefer.

ifosli · 2023-09-26T22:33:37Z

Kickstarter-iOS/Features/ProjectPage/Views/Cells/ReportProjectCell.swift

+import UIKit
+
+internal final class ReportProjectCell: UITableViewCell, ValueCell {
+  let isIpad = AppEnvironment.current.device.userInterfaceIdiom == .pad


This should look at the horizontal size class instead. This is important to make layouts look good on iPad split screen, for example.

ifosli · 2023-09-26T22:34:12Z

Kickstarter-iOS/Features/ProjectPage/Views/ReportProjectLabelView.swift

+struct ReportProjectLabelView: View {
+  let flagged: Bool
+
+  let isIpad = AppEnvironment.current.device.userInterfaceIdiom == .pad


Same here; look at the size class instead of the device type.

ifosli · 2023-09-26T22:34:32Z

Kickstarter-iOS/Features/ProjectPage/Views/ReportProjectLabelView.swift

+    } else {
+      HStack {
+        Text(Strings.Report_this_project_to())
+          .font(Font(UIFont.ksr_footnote()))


I'd suggest using .ksr_body(size: 14) as the font here instead, to match the project subpage cell.

ifosli · 2023-09-26T22:34:50Z

...rojectPamphletContentDataSource_DEPRECATED_09_06_2022/ProjectPamphletContentDataSource.swift

@@ -16,7 +16,7 @@ internal final class ProjectPamphletContentDataSource: ValueCellDataSource {

    let values = [
      ProjectPamphletSubpage.comments(project.stats.commentsCount as Int?, .first),
-      ProjectPamphletSubpage.updates(project.stats.updatesCount as Int?, .last)
+      ProjectPamphletSubpage.updates(project.stats.updatesCount as Int?, .middle)


nit: This file is marked as deprecated - I'm not sure we need this change (or the file?)

Ah yea, good catch. was just making sure all uses of these cells had the right positioning. I'll undo this change. Looking forward to removing this file completely.

Kickstarter-iOS/Features/ProjectPage/Views/ReportProjectLabelView.swift

ifosli · 2023-09-26T22:55:12Z

Kickstarter-iOS/Features/ProjectPage/Views/Cells/ReportProjectCell.swift

I think this cell is still clickable, even when it's already flagged. I'm not 100% sure, since I just overwrote the flagged bool locally to test this (instead of contacting team A to get myself added to the flagged list). Will you double check and make the cell non-interactive if needed?

double checked and the "already reported" label is never tappable. Only when flagged is false do we show the tappable "report this project" label

…ickstarter/ios-oss into mbl-983-already-reported-label

ifosli

Size class stuff looks good - thanks for updating! Accessibility still isn't quite there, but I'll leave it up to you if you want to fix that now or not.

ifosli · 2023-09-28T16:39:39Z

Kickstarter-iOS/Features/ProjectPage/Views/Cells/ReportProjectCell.swift

+    let accessibilityTraits = projectFlagged
+      ? UIAccessibilityTraits.staticText
+      : UIAccessibilityTraits.button
+
+    _ = self
+      |> baseTableViewCellStyle()
+      |> ReportProjectCell.lens.accessibilityTraits .~ accessibilityTraits


Thanks for adding this! Unfortunately, I don't think it does anything currently; we'd need to also set isAccessibilityElement = true and the accessibility label. I don't see an easy way to set the label based on the swiftui child view. So I'd suggest either leaving this alone for now or adding it just for the button state. Ex:

if projectFlagged { self.accessibilityTraits = super.accessibilityTraits self.isAccessibilityElement = false } else { self.accessibilityTraits.insert(.button) self.isAccessibilityElement = true self.accessibilityLabel = Strings.Report_this_project_to() }

oh, good callout! I'll look into this in the next PR

scottkicks added 9 commits September 23, 2023 16:52

create ReportProjectCell to display swiftui view

e49b140

* UITableView cell will be added to the Project Page Table View * Used to display a new swiftui view for the report this project label and already reported label

add new cell below overviewSubpages and pass in project's flagging prop

bc5838c

rename label view

a0b0f3a

layout tableview if needed

5da15cc

needs to be called because we're adding a SwiftUI view to the cell's contentView

conditionally render labels using flagged property

65171d1

cleanup

b4400cd

pass project flagged property along with projectURL to viewcontroller…

5dabfa7

… so we know which label can be tappable

remove temp fix for cyclic graph crash

a692182

scottkicks self-assigned this Sep 23, 2023

scottkicks added the draft label Sep 23, 2023

scottkicks added this to the release-5.11.0 milestone Sep 23, 2023

scottkicks added 7 commits September 23, 2023 18:49

update tests

c6e7492

updateProjectPageViewControllerDataSourceTests tests

57fd4cd

fix pamphletsubpage cell divider

8b3eacf

we don't need to hide it now that there is a new section below it.

fix view styling on iPad

cdc65d4

Merge branch 'mbl-983-already-reported-label' of https://github.com/k…

301cfb7

…ickstarter/ios-oss into mbl-983-already-reported-label

formatting

00c21f4

support more than one hyperlink in a string

ce8e695

kickstarter deleted a comment from nativeksr Sep 25, 2023

scottkicks marked this pull request as ready for review September 25, 2023 17:29

scottkicks requested a review from ifosli September 25, 2023 17:29

scottkicks added needs review enhancement and removed draft labels Sep 25, 2023

scottkicks mentioned this pull request Sep 25, 2023

[MBL-984] Setup CreateFlagging GraphQL Mutation #1858

Merged

2 tasks

ifosli requested changes Sep 26, 2023

View reviewed changes

scottkicks added 2 commits September 27, 2023 10:27

undo change in deprecated file

46528de

update hyperlink urls

3319b02

scottkicks added 3 commits September 27, 2023 11:39

set accessibility traits and cell's traitCollection

18549e8

Merge branch 'main' into mbl-983-already-reported-label

1bbe0ec

Merge branch 'mbl-983-already-reported-label' of https://github.com/k…

62e8c77

…ickstarter/ios-oss into mbl-983-already-reported-label

scottkicks force-pushed the mbl-983-already-reported-label branch 2 times, most recently from bc2ac13 to e7576a2 Compare September 28, 2023 02:11

pop views on successful submissionupdate contraint margins

b38f921

scottkicks force-pushed the mbl-983-already-reported-label branch from e7576a2 to b38f921 Compare September 28, 2023 02:29

scottkicks requested a review from ifosli September 28, 2023 14:12

ifosli approved these changes Sep 28, 2023

View reviewed changes

scottkicks merged commit 8f40c4c into main Sep 28, 2023
7 checks passed

scottkicks deleted the mbl-983-already-reported-label branch September 28, 2023 16:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MBL-983] Already Reported Project Label #1857

[MBL-983] Already Reported Project Label #1857

scottkicks commented Sep 23, 2023 •

edited

codecov bot commented Sep 25, 2023 •

edited

ifosli left a comment

ifosli Sep 26, 2023

ifosli Sep 26, 2023

ifosli Sep 26, 2023

ifosli Sep 26, 2023

scottkicks Sep 27, 2023

ifosli Sep 26, 2023

scottkicks Sep 27, 2023 •

edited

ifosli left a comment

ifosli Sep 28, 2023

scottkicks Sep 28, 2023

[MBL-983] Already Reported Project Label #1857

[MBL-983] Already Reported Project Label #1857

Conversation

scottkicks commented Sep 23, 2023 • edited

📲 What

🤔 Why

🛠 How

👀 See

✅ Acceptance criteria

codecov bot commented Sep 25, 2023 • edited

Codecov Report

ifosli left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scottkicks Sep 27, 2023 • edited

Choose a reason for hiding this comment

ifosli left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scottkicks commented Sep 23, 2023 •

edited

codecov bot commented Sep 25, 2023 •

edited

scottkicks Sep 27, 2023 •

edited