[MBL-984] Setup CreateFlagging GraphQL Mutation #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by running our bin/apollo-schema-download.sh script
updates GraphAPI.swift after building with the new mutation
Codecov Report
@@ Coverage Diff @@
## main #1858 +/- ##
==========================================
- Coverage 83.98% 83.98% -0.01%
==========================================
Files 1283 1287 +4
Lines 116986 117044 +58
Branches 31111 31129 +18
==========================================
+ Hits 98256 98302 +46
- Misses 17643 17655 +12
Partials 1087 1087
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ifosli
approved these changes
Sep 26, 2023
KsApi/ServiceType.swift
Outdated
| @@ -73,6 +73,10 @@ public protocol ServiceType { | |||
|
|
|||
| func createBacking(input: CreateBackingInput) -> | |||
| SignalProducer<CreateBackingEnvelope, ErrorEnvelope> | |||
|
|
|||
| /// Sends report project data to relevant to a specific project | |||
There was a problem hiding this comment.
nit: This sentence doesn't make sense to me. Maybe just "Sends report project data for a specific project"?
There was a problem hiding this comment.
no prob! feel free to suggest smaller changes like this directly in your comment. GitHub lets us commit directly from comments which can be nice.
Generated by 🚫 Danger |
scottkicks
force-pushed
the
create-flagging-mutation
branch
from
fcfc735
to
59c7301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
As part of our Report Project initiative - Update our GraphSchema so that we can use the CreateFlagging mutation.
Latest PR for more context on this initiative
🤔 Why
We'll use this mutation to submit reports to the Trust & Safety team.
The submission view that will utilize this mutation will be built next.
🛠 How
bin/apollo-schema-download.shscript✅ Acceptance criteria
CreateFlaggingmutation is ready to be referenced in the app. This works is to expose the mutation. Implementation will happen next.