Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MBL-1036] Block User Popup + Banner Message #1880
[MBL-1036] Block User Popup + Banner Message #1880
Changes from 11 commits
fbed78a
52bed6c
2d47595
9503d4a
e3c6eeb
594b569
800d1f2
4429bcd
1977b86
824ab38
119684d
9dbf44d
9c03072
06e3236
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 170 in Kickstarter-iOS/Features/Comments/Controllers/CommentRepliesViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/Comments/Controllers/CommentRepliesViewController.swift#L170
Check warning on line 175 in Kickstarter-iOS/Features/Comments/Controllers/CommentRepliesViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/Comments/Controllers/CommentRepliesViewController.swift#L173-L175
Check warning on line 178 in Kickstarter-iOS/Features/Comments/Controllers/CommentRepliesViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/Comments/Controllers/CommentRepliesViewController.swift#L177-L178
Check warning on line 184 in Kickstarter-iOS/Features/Comments/Controllers/CommentRepliesViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/Comments/Controllers/CommentRepliesViewController.swift#L184
Check warning on line 186 in Kickstarter-iOS/Features/Comments/Controllers/CommentRepliesViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/Comments/Controllers/CommentRepliesViewController.swift#L186
Check warning on line 260 in Kickstarter-iOS/Features/Comments/Controllers/CommentRepliesViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/Comments/Controllers/CommentRepliesViewController.swift#L259-L260
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a peek in
MessageBannerViewController
, and it does already referenceself.view.superview
, so it might be safe to moveisUserInteractionEnabled
in there. But that's not a blocker, as previously discussed.Check warning on line 189 in Kickstarter-iOS/Features/Comments/Controllers/CommentsViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/Comments/Controllers/CommentsViewController.swift#L188-L189
Check warning on line 193 in Kickstarter-iOS/Features/Comments/Controllers/CommentsViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/Comments/Controllers/CommentsViewController.swift#L192-L193
Check warning on line 196 in Kickstarter-iOS/Features/Comments/Controllers/CommentsViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/Comments/Controllers/CommentsViewController.swift#L195-L196
Check warning on line 202 in Kickstarter-iOS/Features/Comments/Controllers/CommentsViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/Comments/Controllers/CommentsViewController.swift#L202
Check warning on line 204 in Kickstarter-iOS/Features/Comments/Controllers/CommentsViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/Comments/Controllers/CommentsViewController.swift#L204
Check warning on line 300 in Kickstarter-iOS/Features/Comments/Controllers/CommentsViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/Comments/Controllers/CommentsViewController.swift#L299-L300
Check warning on line 154 in Kickstarter-iOS/Features/MessageBanner/Controller/MessageBannerViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/MessageBanner/Controller/MessageBannerViewController.swift#L154
Check warning on line 34 in Kickstarter-iOS/Features/Messages/Controller/MessagesViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/Messages/Controller/MessagesViewController.swift#L33-L34
Check warning on line 96 in Kickstarter-iOS/Features/Messages/Controller/MessagesViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/Messages/Controller/MessagesViewController.swift#L95-L96
Check warning on line 102 in Kickstarter-iOS/Features/Messages/Controller/MessagesViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/Messages/Controller/MessagesViewController.swift#L100-L102
Check warning on line 105 in Kickstarter-iOS/Features/Messages/Controller/MessagesViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/Messages/Controller/MessagesViewController.swift#L104-L105
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Add a TODO here and for the other banner messages to update them once translated strings are ready
Check warning on line 166 in Kickstarter-iOS/Features/Messages/Controller/MessagesViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/Messages/Controller/MessagesViewController.swift#L166
Check warning on line 168 in Kickstarter-iOS/Features/Messages/Controller/MessagesViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/Messages/Controller/MessagesViewController.swift#L168
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I don't think
author
is the right name in this context - justuser
would be betterCheck warning on line 212 in Kickstarter-iOS/Features/Messages/Controller/MessagesViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/Messages/Controller/MessagesViewController.swift#L212
Check warning on line 546 in Kickstarter-iOS/Features/ProjectPage/Controller/ProjectPageViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/ProjectPage/Controller/ProjectPageViewController.swift#L544-L546
Check warning on line 549 in Kickstarter-iOS/Features/ProjectPage/Controller/ProjectPageViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/ProjectPage/Controller/ProjectPageViewController.swift#L548-L549
Check warning on line 742 in Kickstarter-iOS/Features/ProjectPage/Controller/ProjectPageViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/ProjectPage/Controller/ProjectPageViewController.swift#L742
Check warning on line 744 in Kickstarter-iOS/Features/ProjectPage/Controller/ProjectPageViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/ProjectPage/Controller/ProjectPageViewController.swift#L744
Check warning on line 1096 in Kickstarter-iOS/Features/ProjectPage/Controller/ProjectPageViewController.swift
Codecov / codecov/patch
Kickstarter-iOS/Features/ProjectPage/Controller/ProjectPageViewController.swift#L1096