[MBL-1036] Block User Popup + Banner Message #1880

scottkicks · 2023-11-06T19:37:37Z

📲 What

Presents a confirmation alert when "Block this user" is selected from the block user action sheet
Presents a success or fail Message Banner when tapping block in this new alert. This isn't wired up to an API or anything yet. This behavior is hardcoded for now.

🤔 Why

Rather than sending a blocking request from the action sheet, we're going to use this confirmation alert pattern so that we can provide extra information and double-check that they want to block a user.

🛠 How

The key areas are:

Comments
CommentReplies
ProjectPage
Messages

I'm taking advantage of the existing MessageBannerViewController that we use elsewhere in the app to display API response success and error banners. This means that each ViewController, except ProjectPage, needs to conform to MessageBannerViewControllerPresenting and present an instance of the banner when the corresponding ViewModel outputs a response from the API (which isn't wired up yet).

One caveat is that to keep users from spamming the block action sheet and alert, I'm disabling user interaction on the parent view until the success/error banner message is finished displaying. Once the success banner is dismissed on the project page, we auto-dismiss the view since the user doesn't want to see that content anymore. This could also set us up to more easily refresh our app content.

we won't dismiss when blocking from comments since users could block a user that doesn't own that project.

So basically I've:

added functionality to display a new UIAlert when tapping the action sheet
when tapping Block on this new alert, we trigger an input to the ViewModel (this will eventually kick off our backend request) and then a new userBlocked output notifies the ViewController of which banner to display. Success or error.

👀 See

🦋

✅ Acceptance criteria

Run the AppCenter Beta build. Make sure you're logged in and that the Block User FF is on.

Tapping the Block this user action sheet, from any of the key areas listed above, presents a UIAlert with an option to block or cancel
Tapping block user presents a banner message at the bottom of the screen. (this is temporarily controlled by a manual bool in the view model until we have an API to wire this up to)
If showing the success banner, the parent view is not tappable and dismisses once the banner hides
If showing the error banner, the parent view does not dismiss and users can try to again to block.

…e project page after blocking

…output

…bleviewcontroller * this only needs to be forced in messages and comments

codecov · 2023-11-06T19:45:07Z

Codecov Report

Merging #1880 (06e3236) into main (67e4562) will decrease coverage by 0.07%.
The diff coverage is 15.20%.

@@            Coverage Diff             @@
##             main    #1880      +/-   ##
==========================================
- Coverage   83.83%   83.77%   -0.07%     
==========================================
  Files        1224     1224              
  Lines      111349   111457     +108     
  Branches    29601    29636      +35     
==========================================
+ Hits        93349    93368      +19     
- Misses      16989    17073      +84     
- Partials     1011     1016       +5

Files	Coverage Δ
Library/ViewModels/CommentRepliesViewModel.swift	`98.24% <40.00%> (-1.76%)`	⬇️
Library/ViewModels/CommentsViewModel.swift	`98.57% <40.00%> (-0.85%)`	⬇️
Library/ViewModels/MessagesViewModel.swift	`94.78% <40.00%> (-2.50%)`	⬇️
Library/ViewModels/ProjectPageViewModel.swift	`96.21% <25.00%> (-0.78%)`	⬇️
...anner/Controller/MessageBannerViewController.swift	`67.44% <42.85%> (-1.92%)`	⬇️
...nts/Controllers/CommentRepliesViewController.swift	`54.05% <16.66%> (-3.41%)`	⬇️
.../Comments/Controllers/CommentsViewController.swift	`66.66% <16.66%> (-4.20%)`	⬇️
...ectPage/Controller/ProjectPageViewController.swift	`49.17% <15.78%> (-0.76%)`	⬇️
...s/Messages/Controller/MessagesViewController.swift	`0.00% <0.00%> (ø)`
Library/UIAlertController.swift	`0.64% <0.00%> (-0.06%)`	⬇️

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

…ng displayed

Kickstarter-iOS/Features/MessageBanner/Controller/MessageBannerViewController.swift

Kickstarter-iOS/Features/Messages/Controller/MessagesViewController.swift

Kickstarter-iOS/Features/Comments/Controllers/CommentRepliesViewController.swift

…e the banner stretches to the width of its parent view

amy-at-kickstarter · 2023-11-08T15:42:41Z

Kickstarter-iOS/Features/Comments/Controllers/CommentRepliesViewController.swift

+extension CommentRepliesViewController: MessageBannerViewControllerDelegate {
+  func messageBannerViewDidHide(type _: MessageBannerType) {
+    self.commentComposer.isHidden = false
+    self.view.isUserInteractionEnabled = true


I took a peek in MessageBannerViewController, and it does already reference self.view.superview, so it might be safe to move isUserInteractionEnabled in there. But that's not a blocker, as previously discussed.

amy-at-kickstarter

I didn't test on my machine, but 👀 code LGTM.

…oller

ifosli

Looks good! I added some nits that would be nice to fix before merging, but I don't think any of them are complicated enough that they'll require another review pass.

ifosli · 2023-11-08T18:10:35Z

Kickstarter-iOS/Features/Messages/Controller/MessagesViewController.swift

+            .showBanner(with: .success, message: "This user has been successfully blocked")
+        } else {
+          self?.messageBannerViewController?
+            .showBanner(with: .error, message: "Your request did not go through. Try again.")


Nit: Add a TODO here and for the other banner messages to update them once translated strings are ready

ifosli · 2023-11-08T18:12:42Z

Kickstarter-iOS/Features/Messages/Controller/MessagesViewController.swift

@@ -170,16 +189,26 @@ extension MessagesViewController: BackingCellDelegate {
 // MARK: - MessageCellDelegate

 extension MessagesViewController: MessageCellDelegate {
-  func messageCellDidTapHeader(_ cell: MessageCell, _: User) {
+  func messageCellDidTapHeader(_ cell: MessageCell, _ author: User) {


Nit: I don't think author is the right name in this context - just user would be better

ifosli · 2023-11-08T18:21:16Z

Kickstarter-iOS/Features/MessageBanner/Controller/MessageBannerViewController.swift

@@ -99,6 +108,7 @@ public final class MessageBannerViewController: UIViewController, NibLoading {

    if !isHidden {
      self.view.superview?.bringSubviewToFront(self.view)
+      self.view.superview?.isUserInteractionEnabled = false


Did you want the message banner class to be responsible for turning on and off user interaction? I'm okay with that (as long as that works for all current call sites), but then the corresponding lines of code in the individual classes need to be deleted.

Yep - It does work for the other call sites. Good catch. I thought I had gotten them all. Will remove it from the last 2 classes.

scottkicks added 8 commits November 2, 2023 09:57

present Popup alert when tapping Block user from action sheet

fbed78a

add delegate to MessageBannerViewController so that we can dismiss th…

52bed6c

…e project page after blocking

add blockUser input to project page view model

2d47595

show success/fail messageBanner based on project page VM userBlocked …

9503d4a

…output

show popup + banners in comment replies

e3c6eeb

show popup + banners on comments

594b569

show popup + banners in messages

800d1f2

message banner should extend full screen width when displayed in a ta…

4429bcd

…bleviewcontroller * this only needs to be forced in messages and comments

scottkicks self-assigned this Nov 6, 2023

scottkicks added the draft label Nov 6, 2023

scottkicks added this to the release-5.11.0 milestone Nov 6, 2023

scottkicks added 2 commits November 6, 2023 13:57

Merge branch 'main' into scott/block-user-popup

1977b86

disable userinteraction on comments and messaging while banner is bei…

824ab38

…ng displayed

scottkicks force-pushed the scott/block-user-popup branch from 1d303f8 to 824ab38 Compare November 7, 2023 16:48

scottkicks added enhancement needs review and removed draft labels Nov 7, 2023

scottkicks marked this pull request as ready for review November 7, 2023 17:15

scottkicks requested review from ifosli and amy-at-kickstarter November 7, 2023 17:15

amy-at-kickstarter reviewed Nov 7, 2023

View reviewed changes

Kickstarter-iOS/Features/MessageBanner/Controller/MessageBannerViewController.swift Show resolved Hide resolved

amy-at-kickstarter reviewed Nov 7, 2023

View reviewed changes

Kickstarter-iOS/Features/Messages/Controller/MessagesViewController.swift Outdated Show resolved Hide resolved

amy-at-kickstarter reviewed Nov 7, 2023

View reviewed changes

Kickstarter-iOS/Features/Comments/Controllers/CommentRepliesViewController.swift Outdated Show resolved Hide resolved

set message banner widthAnchor instead of left/right anchors to ensur…

119684d

…e the banner stretches to the width of its parent view

scottkicks requested a review from amy-at-kickstarter November 8, 2023 14:56

amy-at-kickstarter reviewed Nov 8, 2023

View reviewed changes

amy-at-kickstarter approved these changes Nov 8, 2023

View reviewed changes

move isUserInteractionEnabled functionality to MessageBannerViewContr…

9dbf44d

…oller

ifosli approved these changes Nov 8, 2023

View reviewed changes

scottkicks added 2 commits November 8, 2023 14:49

feedback

9c03072

Merge branch 'main' into scott/block-user-popup

06e3236

scottkicks merged commit 6abd404 into main Nov 9, 2023
7 checks passed

scottkicks deleted the scott/block-user-popup branch November 9, 2023 13:17

ifosli pushed a commit that referenced this pull request Nov 13, 2023

[MBL-1036] Block User Popup + Banner Message (#1880)

742f4a3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MBL-1036] Block User Popup + Banner Message #1880

[MBL-1036] Block User Popup + Banner Message #1880

scottkicks commented Nov 6, 2023 •

edited

codecov bot commented Nov 6, 2023 •

edited

amy-at-kickstarter Nov 8, 2023

amy-at-kickstarter left a comment

ifosli left a comment

ifosli Nov 8, 2023

ifosli Nov 8, 2023

ifosli Nov 8, 2023

scottkicks Nov 8, 2023

[MBL-1036] Block User Popup + Banner Message #1880

[MBL-1036] Block User Popup + Banner Message #1880

Conversation

scottkicks commented Nov 6, 2023 • edited

📲 What

🤔 Why

🛠 How

👀 See

✅ Acceptance criteria

codecov bot commented Nov 6, 2023 • edited

Codecov Report

amy-at-kickstarter Nov 8, 2023

Choose a reason for hiding this comment

amy-at-kickstarter left a comment

Choose a reason for hiding this comment

ifosli left a comment

Choose a reason for hiding this comment

ifosli Nov 8, 2023

Choose a reason for hiding this comment

ifosli Nov 8, 2023

Choose a reason for hiding this comment

ifosli Nov 8, 2023

Choose a reason for hiding this comment

scottkicks Nov 8, 2023

Choose a reason for hiding this comment

scottkicks commented Nov 6, 2023 •

edited

codecov bot commented Nov 6, 2023 •

edited