Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-904: Remove feature flag for tab "Use of AI" #1914

Merged
merged 3 commits into from Jan 23, 2024

Conversation

amy-at-kickstarter
Copy link
Contributor

@amy-at-kickstarter amy-at-kickstarter commented Jan 17, 2024

📲 What

Remove the feature flag that controlled the "Use of AI" tab.

🤔 Why

We're no longer testing this feature.

👀 See

Just to double-check: the tab still works! The tab is also covered by ProjectPageViewControllerTests.
Screenshot 2024-01-17 at 1 20 36 PM

@amy-at-kickstarter amy-at-kickstarter marked this pull request as ready for review January 17, 2024 18:21
@amy-at-kickstarter amy-at-kickstarter self-assigned this Jan 17, 2024
@amy-at-kickstarter amy-at-kickstarter force-pushed the feat/adyer/mbl-904/remove-use-of-ai-flag branch from ebb41ad to 0bb83bf Compare January 17, 2024 18:22
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (66e61bd) 83.75% compared to head (c2bade8) 83.75%.

Files Patch % Lines
...iewModels/ProjectNavigationSelectorViewModel.swift 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1914   +/-   ##
=======================================
  Coverage   83.75%   83.75%           
=======================================
  Files        1223     1223           
  Lines      111811   111784   -27     
  Branches    29750    29734   -16     
=======================================
- Hits        93642    93621   -21     
+ Misses      17147    17142    -5     
+ Partials     1022     1021    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amy-at-kickstarter amy-at-kickstarter force-pushed the feat/adyer/mbl-904/remove-use-of-ai-flag branch from c1818d1 to a5f61ac Compare January 19, 2024 17:15
Copy link
Contributor

@ifosli ifosli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just keep an eye out when merging, since there's been a new flag added since the pr was opened.

@amy-at-kickstarter amy-at-kickstarter force-pushed the feat/adyer/mbl-904/remove-use-of-ai-flag branch from a5f61ac to 46233c0 Compare January 23, 2024 15:53
@amy-at-kickstarter amy-at-kickstarter merged commit 890fc8a into main Jan 23, 2024
5 checks passed
@amy-at-kickstarter amy-at-kickstarter deleted the feat/adyer/mbl-904/remove-use-of-ai-flag branch January 23, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants