Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1305] Revert banner changes #2011

Merged
merged 3 commits into from Apr 1, 2024
Merged

[MBL-1305] Revert banner changes #2011

merged 3 commits into from Apr 1, 2024

Conversation

ifosli
Copy link
Contributor

@ifosli ifosli commented Apr 1, 2024

📲 What

Revert banner changes as we want to start the checkout flow over from the beginning if checkout goes wrong, and the confirm checkout VC is designed to create the checkout id.

Hopefully we'll restructure this for a better user experience in the future, but for now, this was the flow that eng across platforms decided on.

👀 See

Jira

@ifosli ifosli self-assigned this Apr 1, 2024
@ifosli ifosli marked this pull request as ready for review April 1, 2024 20:24
@ifosli ifosli requested review from a team and scottkicks and removed request for a team April 1, 2024 20:25
Copy link
Contributor

@scottkicks scottkicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Sorry, again, for the confusion around this

@ifosli ifosli merged commit 9cb264c into main Apr 1, 2024
5 checks passed
@ifosli ifosli deleted the revertBannerChanges branch April 1, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants