Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MBL-1305] Revert banner changes #2011

Merged
merged 3 commits into from
Apr 1, 2024
+16 −0
Merged

[MBL-1305] Revert banner changes #2011

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56d540d
Revert "Don't pop view controller when banner dismisses (#2007)"
ifosli Apr 1, 2024
364eac1
Add comment for clarification
ifosli Apr 1, 2024
e28fd3e
Merge branch 'main' into revertBannerChanges
ifosli Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 14 additions & 0 deletions Kickstarter-iOS/Features/PledgeView/Controllers/PostCampaignCheckoutViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ final class PostCampaignCheckoutViewController: UIViewController, MessageBannerV
self.title = Strings.Back_this_project()

self.messageBannerViewController = self.configureMessageBannerViewController(on: self)
self.messageBannerViewController?.delegate = self

self.configureChildViewControllers()
self.setupConstraints()
Expand Down Expand Up @@ -399,6 +400,19 @@ extension PostCampaignCheckoutViewController: PledgeViewControllerMessageDisplay

// MARK: - MessageBannerViewControllerDelegate

extension PostCampaignCheckoutViewController: MessageBannerViewControllerDelegate {
func messageBannerViewDidHide(type: MessageBannerType) {
switch type {
case .error:
// Pop view controller in order to start checkout flow from the beginning,
// starting with generating a new checkout id.
self.navigationController?.popViewController(animated: true)
default:
break
}
}
}

extension PostCampaignCheckoutViewController: PKPaymentAuthorizationViewControllerDelegate {
func paymentAuthorizationViewControllerDidFinish(_ controller: PKPaymentAuthorizationViewController) {
controller.dismiss(animated: true, completion: { [weak self] in
Expand Down