Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1358] Add Privacy Manifest File #2045

Merged
merged 3 commits into from
Apr 23, 2024
Merged

[MBL-1358] Add Privacy Manifest File #2045

merged 3 commits into from
Apr 23, 2024

Conversation

scottkicks
Copy link
Contributor

… type and reason

📲 What

Creates a new Privacy Manifest file and includes the missing reasons for our use of the called out NSPrivacyAccessedAPICategory types

🤔 Why

From Apple:

Missing API declaration - Your app’s code in the “Kickstarter” file references one or more APIs that require reasons, including the following API categories: 
- NSPrivacyAccessedAPICategoryUserDefaults
- NSPrivacyAccessedAPICategoryFileTimestamp
Screenshot 2024-04-23 at 10 50 41 AM

We need to provide appropriate reasoning for these or else we won't be accepted in the App Store.

🛠 How

  • Creates a new PrivacyInfo.xcprivacy following Apple's docs
  • Adds the NSPrivacyAccessedAPICategoryUserDefaults type and reason following these apple docs

We aren't using the NSPrivacyAccessedAPICategoryFileTimestamp type internally. Rather, it looks like Kingfisher does. Specifically, they use: modificationDate, creationDate, contentModificationDateKey, and creationDateKey

  • I think the solution here is to update Kingfisher to >= 7.10.0 (the version where they updated their privacy manifest) instead of updating our manifest. We're reaching out to Apple to hopefully get some clarity on that. It might not be a big deal to update the version anyway.

👀 See

Screenshot 2024-04-23 at 10 59 04 AM

@scottkicks scottkicks self-assigned this Apr 23, 2024
@scottkicks scottkicks mentioned this pull request Apr 23, 2024
2 tasks
@scottkicks scottkicks requested review from a team and amy-at-kickstarter and removed request for a team April 23, 2024 18:02
@scottkicks scottkicks marked this pull request as ready for review April 23, 2024 18:02
Copy link
Contributor

@amy-at-kickstarter amy-at-kickstarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Makes sense, we just use defaults for our own local storage.

@scottkicks scottkicks merged commit 52b91fb into main Apr 23, 2024
5 checks passed
@scottkicks scottkicks deleted the scott/mbl-1358 branch April 23, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants