Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1358] Update Kingfisher #2046

Merged
merged 2 commits into from
Apr 23, 2024
Merged

[MBL-1358] Update Kingfisher #2046

merged 2 commits into from
Apr 23, 2024

Conversation

scottkicks
Copy link
Contributor

@scottkicks scottkicks commented Apr 23, 2024

πŸ“² What

Updates min version to 7.10.0 up to next major version 7.11.0 (Latest).

πŸ€” Why

Main reference for what's going on

But, Apple requires us to give reasons for using certain APIs. Reasons that need to be added to a Privacy Manifest file (added in that PR ☝️ )

One of the APIs that our app is missing a reason for is NSPrivacyAccessedAPICategoryFileTimestamp.
We aren't actually using this API internally, Kingfisher is.

Kingfisher added privacy support for Apple's new requirement in 7.10.0. So, by updating the version we're using we should now be meeting the requirement.

  • I'm not certain that we don't still need to include a reason for how the 3rd party is using this API as well, but we've reached out to apple support for clarification. For now we're going to update anyway since it has minimal impact.

πŸ›  How

set minimum version to 7.10.0 (version that they added privacy support) up to next major version (7.11.0)

πŸ‘€ See

Kingfisher's Privacy Manifest which contains the File Timestamp type and reason that Apple is warning us about.

Screenshot 2024-04-23 at 11 59 16β€―AM

βœ… Acceptance criteria

  • The app runs as normal. Specifically image loading. I ran through som regression test steps as well to cover more cases.
  • All tests pass

@scottkicks scottkicks self-assigned this Apr 23, 2024
@scottkicks scottkicks marked this pull request as ready for review April 23, 2024 18:02
Copy link
Contributor

@amy-at-kickstarter amy-at-kickstarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will be interesting to hear what Apple says.

@scottkicks scottkicks merged commit 305f265 into main Apr 23, 2024
5 checks passed
@scottkicks scottkicks deleted the scott/update-kingfisher branch April 23, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants