Thankyou card bug fix #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you perhaps add a link to the PR where the type was added? |
|
@justinswart added the PR link to the description! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Bug fix for unresponsive thank you cards in the thank you page. I introduced this when I added project categories into the cards, and missed a spot that needed to be updated to reflect the new data source type 😭We actually had a test for this scenario that would have failed, but the test file wasn't added to the list of sources, so it wasn't run. This PR fixes the bug and adds the
ThanksProjectDataSourceTestsinto the framework test target.I've also removed the
DiscoveryPostcardCellview from theDiscoveryPagestoryboard. We don't use this anymore because we have aDiscoveryPostcardCell.xibthat we reuse in the thank you page. Tested on both the regular discover view and the thank you screen.Why
https://trello.com/c/oRcheQCq/763-ios-post-pledge-thank-you-page-project-recommendation-cards-are-unresponsive
See 👀
Original PR: #347
Video: